Fix runtime warning: assertion 'EV_IS_VIEW (view)' failed

mate-desktop / atril

A document viewer for MATE

http://www.mate-desktop.org

GNU General Public License v2.0

197 stars 62 forks source link

Fix runtime warning: assertion 'EV_IS_VIEW (view)' failed #569

Closed rbuj closed 1 year ago

rbuj commented 1 year ago

Test: open an epub file (epub30-spec.epub), next check ~/.xsession-errors log

$ cat ~/.xsession-errors
(atril:1841): GLib-GObject-WARNING **: 20:24:14.659: invalid unclassed pointer in cast to 'EvView'

(atril:1841): AtrilView-CRITICAL **: 20:24:14.659: ev_view_is_caret_navigation_enabled: assertion 'EV_IS_VIEW (view)' failed

lukefromdc commented 1 year ago

Not getting that warning on Debian Unstable. All I get is (atril:275871): Gdk-WARNING **: 15:44:41.142: ../gdk/x11/gdkwindow-x11.c:5653 drawable is not a native X11 window which is something else

lukefromdc commented 1 year ago

Change is very simple with little potential to create trouble. Tested caret navigation on a PDF and it worked with this applied, just in case.

EDIT: if possible, someone who can reproduce the error should test this. If not I can merge this later