search

mate-desktop / atril

A document viewer for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
197 stars 62 forks source link

support webkit2gtk-4.1and 4.0 #583

Closed raveit65 closed 1 year ago

raveit65 commented 1 year ago
raveit65 commented 1 year ago

@vkareh I didn't know about libsoup issue in f38. Can you please open an rhbz? I don't want to forget to update fedora.

raveit65 commented 1 year ago

@vkareh So this 5 days old version has this issue? https://bodhi.fedoraproject.org/updates/FEDORA-2023-2fc666d008

vkareh commented 1 year ago

@raveit65 I just compiled from master and tried opening an epub. Got this error:

(atril:141091): libsoup-ERROR **: 10:51:05.288: libsoup2 symbols detected. Using libsoup2 and libsoup3 in the same process is not supported.

And Atril crashed without opening the file.

raveit65 commented 1 year ago

Just update CI to build with webkit2-4.1

raveit65 commented 1 year ago

@raveit65 I just compiled from master and tried opening an epub. Got this error:

(atril:141091): libsoup-ERROR **: 10:51:05.288: libsoup2 symbols detected. Using libsoup2 and libsoup3 in the same process is not supported.

And Atril crashed without opening the file.

Ok, i will cherry pick that to 1.26 branch and update fedora f37+

raveit65 commented 1 year ago

@vkareh Btw. what -devel package is installed in your box? Fedora support both version with one SRPM.

[root@mother rave]# dnf search webkit2gtk4*-devel
Letzte Prüfung auf abgelaufene Metadaten: vor 0:01:33 am Do 04 Mai 2023 17:09:03 CEST.
======================= Name Treffer: webkit2gtk4*-devel =======================
webkit2gtk4.0-devel.x86_64 : Development files for webkit2gtk4.0
webkit2gtk4.0-devel.i686 : Development files for webkit2gtk4.0
webkit2gtk4.1-devel.i686 : Development files for webkit2gtk4.1
webkit2gtk4.1-devel.x86_64 : Development files for webkit2gtk4.1
vkareh commented 1 year ago

Btw. what -devel package is installed in your box?

$ dnf info --installed  webkit2gtk4\*devel | grep ^Name
Name         : webkit2gtk4.0-devel
Name         : webkit2gtk4.1-devel

They are both sourced from the same webkitgtk-2.40.1-1.fc38.src.rpm

raveit65 commented 1 year ago

Maybe remove one -devel source? Because i can't reproduce your issue with fedora official 1.26.1 rpm which was build against old obsolete webkit2gtk3-devel. Also i don't see this issue with my local 1.7.0 build which use webkit2gtk4.0-devel as source.