search

mate-desktop / atril

A document viewer for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
197 stars 62 forks source link

fix a incompatible pointer type warning for gcc14 #604

Closed raveit65 closed 5 months ago

raveit65 commented 5 months ago

closes https://github.com/mate-desktop/atril/issues/603

raveit65 commented 5 months ago

wtf, commit suggest from conversation did only add one line.

cwendling commented 5 months ago

@raveit65 I didn't add it to the second occurrence because I didn't think it was a necessary change, but merely a possible improvement; and you can only have one suggestion per individual hunk, so I couldn't do both at once. It's no biggie, but maybe we want to harmonize this in a follow-up :)

raveit65 commented 5 months ago

I pushed an update to master :-)

cwendling commented 5 months ago

@raveit65 I see :) Though, I'd rather use the same technique in both instance, rather than 2 different ones

raveit65 commented 5 months ago

It was a kind of bad website automatism. After i added the first suggestion github marked/closed the conversation as resolved and i thought both suggestions were added. Than i squashed and merged the PR without checking the commit again. ...good i learnt how a small github detail is working :)