search

mate-desktop / caja

Caja, the file manager for the MATE desktop
https://mate-desktop.org/
Other
265 stars 143 forks source link

Revert "caja-desktop-window: Fix the xrandr error" #1725

Closed raveit65 closed 1 year ago

raveit65 commented 1 year ago

Reverts mate-desktop/caja#1724

lukefromdc commented 1 year ago

Did you find an issue with this beyond the deprecation? Reverting will bring back the situation where some users must restart caja after changing screen orientation, which is admittedly an unusual case.

Before I merged the commit this reverts, I tested scaling changes, desktop resolution changes, rotation changes, and even multimonitor and in x11 it was the one option out of three tested that always worked. The previous code generated rendering issues on rotation of the screen and back, and using my wayland code in x11 caused a second monitor to not be used by Caja and in compiz that means no-redraw rendering messes in the unused area. In all cases restarting caja will clear this.

It is entirely possible NO really good solution exists

I am OK with this either way, what does everyone else think?

zhuyaliang commented 1 year ago

@raveit65 @lukefromdc I will handle this problem and find a better way to solve it

lukefromdc commented 1 year ago

See https://github.com/mate-desktop/caja/pull/1727 if you have something better feel free to submit an alternate PR and I will subject it to my full battery of tests

https://github.com/mate-desktop/caja/pull/1727 anchors the x11 desktop window to the root window, and passed all my tests: rotate, change resolution, change scaling, change number of monitors. That's still one machine, one GTK version, one underlyng OS however