mate-desktop / caja

Caja, the file manager for the MATE desktop
https://mate-desktop.org/
Other
265 stars 143 forks source link

Replace deprecated code from xrandr fix #1727

Closed lukefromdc closed 1 year ago

lukefromdc commented 1 year ago

In x11 we can anchor the desktop size to the root window instead of the screen or (possibly multiple)monitors

raveit65 commented 1 year ago

Thanks for the quick fix. Should i push both commits (squashed) to 1.26 branch? Because the xrandr commit fixes a long outstanding issue.

lukefromdc commented 1 year ago

I would advise doing so, and for distros to pick it up they will need a new release of 1.26

jonathanbower commented 8 months ago

Hi @raveit65 , will this fix be committed to 1.26?

raveit65 commented 8 months ago

It's only a replacement of deprecated code. Function is same like before and it doesn't fix any bug. We back port only bug fixes to stable branches. Commit header is a bit misleading.

jonathanbower commented 8 months ago

Yes sorry, I was actually referring to https://github.com/mate-desktop/caja/pull/1724

raveit65 commented 8 months ago

https://github.com/mate-desktop/caja/pull/1724 seems to be a fix for https://github.com/mate-desktop/caja/issues/1096 @mouse @lukefromdc Is this ready for stable branch?

zhuyaliang commented 8 months ago

1724 has been merged into the master branch

1727 Fix deprecated code

raveit65 commented 8 months ago

The question was to cherry-pick https://github.com/mate-desktop/caja/pull/1724 to 1.26 branch because it seems to be a bugfix, or not.

lukefromdc commented 8 months ago

Probably a good idea to cherrypick both of them together

Mouse commented 8 months ago

1724 seems to be a fix for #1096 @Mouse @lukefromdc Is this ready for stable branch?

Not to actually interrupt, but jokingly, I wouldn't know. I am most definitely not involved with this project =)

raveit65 commented 8 months ago

Done and released https://github.com/mate-desktop/caja/releases/tag/v1.26.3

jonathanbower commented 8 months ago

Done and released https://github.com/mate-desktop/caja/releases/tag/v1.26.3

Thanks!

lukefromdc commented 8 months ago

Seems to be ready on my end, I've had absolutely no trouble from it