mate-desktop / caja

Caja, the file manager for the MATE desktop
https://mate-desktop.org/
Other
265 stars 143 forks source link

wayland background: use mate-appearance-properties if we can #1771

Open lukefromdc opened 3 months ago

lukefromdc commented 3 months ago

In the wayland session, we now have mate-settings-daemon with GDK_BACKEND=x11 We need it to control theming in xwayland apps *So we can now use mate-appearance-properties to set the desktop background when it is running

*To support standalone use of caja in any wayland session when mate-settings-daemon is not running or when mate-control-center is not installed, we use the standalone wayland dialog in those cases

lukefromdc commented 3 months ago

No need to update anything else to use it so hoping this will be OK for 1.28 as wayland is considered experimental, nothing changes for the production x11 session, and it doesn't change any dependencies due to the fallbacks.

If not, bumping version to 1.29 for wayland development is also fine with me.

lukefromdc commented 3 months ago

Latest force-push loses the system() calls, uses g_spawn_command_line_async() instead, and uses the GError variable to determine directly whether we have a version of mate-appearance-properties that can run in wayland directly or not.

Takes advantage of https://github.com/mate-desktop/mate-control-center/pull/749 but does not depend on it because if mate-appearance-properties fails, we just fall back to the standalone wayland dialog

lukefromdc commented 3 months ago

Bumped version in master to 1.29 so we can use this whether or not we want to include it in the next 1.28 release. In this case, nothing breaks if used with an older version of mate-control-center (predating https://github.com/mate-desktop/mate-control-center/pull/749) but the next PR opened by anyone could have a hard dependency on another, so I figured time to bump version in master. Many projects do this as soon as they release a major version

lukefromdc commented 1 week ago

Anyone want to have a look at this one?