mate-desktop / eom

An image viewer for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
58 stars 32 forks source link

add support for webp file #104

Closed hanaokaiwa closed 9 years ago

hanaokaiwa commented 9 years ago

Eye of Mate does not support webp file on my fedora 22. Here is what I installed. $ rpm -q eom eom-1.10.3-1.fc22.x86_64

But if I display "Image Collection" bar, I can see thumb of some of the webp images. Please add support for webp files so I ccould use Eye of Mate only to view images.

infirit commented 9 years ago

So eom, like eog, does not handle the imageg directly and relies on gdk-pixbuf loaders. There is a bug open with the webp ppl here, https://code.google.com/p/webp/issues/detail?id=227. When that is fixed eom will automatically be able to load webp files.

pirate486743186 commented 6 years ago

an update on this?

EDIT: please reopen. webplib will not do it...

Supporting gdk-pixbuf loader directly within libwebp is outside of the intended initial scope

neither gdk-pixbuf

Why? What would be gained by having an in-tree loader, outside of potential new CVEs and additional maintenance burden, for a format that is not used for icons?

https://bugzilla.gnome.org/show_bug.cgi?id=670379

baryluk commented 4 years ago

Still not working.

I suppose the newer tracking bug was https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/103

but it also got closed because 'libwebp' library doesn't support pixbuf. Which is quite ridiculous to expect from the image decoding library. It is not a job of any image decoding library to support pixbuf.

There is some off the tree loader to do that: https://github.com/aruiz/webp-pixbuf-loader/blob/master/io-webp.c , which is the correct approach, and it does work. The security concerns should be handled via sandboxing and seccomp.

Ygarr commented 4 years ago

EOM 1.24.1 still no support

rbuj commented 4 years ago

This feature was added on EOM 1.24, but you need to install the package webp-pixbuf-loader, for instance on Fedora:

$ sudo dnf install -y webp-pixbuf-loader
$ rpm -qi webp-pixbuf-loader
Name        : webp-pixbuf-loader
Version     : 0.0.1
Release     : 9.20191003gitfb04954.fc32
Architecture: x86_64
Install Date: Sun Sep 20 12:19:44 2020
Group       : Unspecified
Size        : 46746
License     : LGPLv2+
Signature   : RSA/SHA256, Fri Jan 31 23:35:07 2020, Key ID 6c13026d12c944d0
Source RPM  : webp-pixbuf-loader-0.0.1-9.20191003gitfb04954.fc32.src.rpm
Build Date  : Fri Jan 31 07:17:54 2020
Build Host  : buildvm-09.phx2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://github.com/aruiz/webp-pixbuf-loader
Bug URL     : https://bugz.fedoraproject.org/webp-pixbuf-loader
Summary     : WebP image loader for GTK+ applications
Description :
webp-pixbuf-loader contains a plugin to load WebP images in GTK+ applications

Screenshot at 2020-09-20 12-22-05

baryluk commented 4 years ago

That is great. Thanks.

Unfortunately webp-pixbuf-loader is not in Debian, Ubuntu. Yet. One step at a time :) PS. It is being requested: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951113 and https://salsa.debian.org/okias-guest/webp-pixbuf-loader looks to be updated few hours ago with some new stuff, so it is comming.

eog people also appears to be working on the support in their code, and made it to work with the same loader.

lukefromdc commented 4 years ago

Confirm we don't have it here in Debian Unstable yet

silpol commented 3 years ago

Current debian packaging can be found here via Debian Bug report logs - #951113 ITP: webp-pixbuf-loader -- WebP Image format GdkPixbuf loader.

lukefromdc commented 3 years ago

Just built the upstream package from source and it works: EOM can display WebP files with this installed. Debian themselves just need to package this in their usual repos