mate-desktop / eom

An image viewer for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
57 stars 32 forks source link

eom-window: update image counter even if current thumbnail is for failed image #346

Closed whatdoineed2do closed 10 months ago

whatdoineed2do commented 11 months ago

To reproduce:

Post fix:

raveit65 commented 11 months ago

Sorry i can't test your branch locally, please rebase with master.

[rave@mother eom]$ git branch
1.26
* master

[rave@mother eom]$ git checkout -b whatdoineed2do-statusbar-imagepos-bug master
Switched to a new branch 'whatdoineed2do-statusbar-imagepos-bug'

[rave@mother eom]$ git pull https://github.com/whatdoineed2do/eom.git statusbar-imagepos-bug
From https://github.com/whatdoineed2do/eom
* branch            statusbar-imagepos-bug -> FETCH_HEAD
hint: Diverging branches can't be fast-forwarded, you need to either:
hint:
hint:   git merge --no-ff
hint:
hint: or:
hint:
hint:   git rebase
hint:
hint: Disable this message with "git config advice.diverging false"
fatal: Not possible to fast-forward, aborting.
[rave@mother eom]$
whatdoineed2do commented 11 months ago

rebased and pushed, please see if you can validate

raveit65 commented 11 months ago

Thx, it works now.

raveit65 commented 10 months ago

You only need to create a text file with image file extension, eg. png. This will trigger the issue....

lukefromdc commented 10 months ago

used your test with a "text.jpg" file and it worked: statusbar counter only updates properly with this applied