search

mate-desktop / libmatemixer

Mixer library for MATE Desktop
https://mate-desktop.org/
GNU Lesser General Public License v2.1
14 stars 10 forks source link

libmatemixer: Remove weak pointers on dispose #40

Closed ProMarbler14 closed 1 year ago

ProMarbler14 commented 1 year ago

Weak pointers are happily overwriting freed object memory (and newly created structures) whenever a weakly referenced object outlives the object storing the reference. Remove those callbacks when they are no longer needed.

Fixes #39

raveit65 commented 1 year ago

As i am not affected by this bug for myself when plug/unplug a device i can't say if this helps. In a first runtime test everything seems to work as usual. I will search for report for this issue and ask for testing this PR. I can also do a test rpm build for fedora and ask for testing in rhbz.

lukefromdc commented 1 year ago

Any updates on testing this? Note that I have kept this installed and haven't had any behavioral changes in recording or playing audio but never got the crash before or after this either

raveit65 commented 1 year ago

I got positive results from 3 reports at rhbz by a user some days ago, but i wait for a final conformation. https://bugzilla.redhat.com/show_bug.cgi?id=2223656#c18 https://bugzilla.redhat.com/show_bug.cgi?id=2223657#c18 https://bugzilla.redhat.com/show_bug.cgi?id=2222196#c15

raveit65 commented 1 year ago

@ProMarbler14 Thanks a lot. Are you interested in maintaining libmatemixer and mate-media? Those packages are unmaintained since years.