Mate Alt-Tab window focus cycle frame

[vistad]

Expected behaviour : I expect the focus frame to be clearly visible.

I am using a dark theme and the black Alt-Tab window focus cycle frame is very hard to see in the dark theme. It is a torture and a huge waste of time trying to see which window is selected.

My problem is described here: https://forums.linuxmint.com/viewtopic.php?f=206&t=292655 I'd like to be able to change the frame color and width! Please help

Alt-Tab between the windows and note the focus frame poor visibility.

MATE general version: Linux Mint Mate 19.3.

Package version

Linux Distribution

Link to downstream report of your Distribution

[cwendling]

I guess I'm having the same issue, which AFAICT depends on the theme (I'm having it with Adwaita). The highlight of the selected window is not using the theme's selection color, and results in very poor visibility. I didn't report it yet because I didn't take the time to properly try the latest dev version, though.

Anyway, a probably relevant piece of info is that Marco is spewing warnings like that if I enable debugging:

(marco:1093867): Gtk-DEBUG: 11:50:13.409: State 4 for GtkWindow 0x561ab9210a70 doesn't match state 128 set via gtk_style_context_set_state ()

Which suggests it's using an incorrect style selector.

Anyway, I'm not sure I'll have time to dig in this, but it'd be worth fixing indeed if it's not specific to a bug in my current setup.

[cdplayer]

Concur that the hilite of each item is not distinct enough, especially on dark background themes. Should not be hardcoded. I am using Mint-Y-Dark. Should be able to override if it's part of theme

[Baregamyan]

Expected behaviour : I expect the focus frame to be clearly visible.

I am using a dark theme and the black Alt-Tab window focus cycle frame is very hard to see in the dark theme. It is a torture and a huge waste of time trying to see which window is selected.

My problem is described here: https://forums.linuxmint.com/viewtopic.php?f=206&t=292655 I'd like to be able to change the frame color and width! Please help

Alt-Tab between the windows and note the focus frame poor visibility.

MATE general version: Linux Mint Mate 19.3.

Package version

Linux Distribution

Link to downstream report of your Distribution

Dear Vistad. I have had the same problem! My fix: just update your Ubuntu 19.3 to 20.4 version. It really works.

[vistad]

Thank you for your info! I'm looking forward to the bug fixing, but I am on Linux Mint Mate 19.3. I'll try the update!

On Sun, Jun 7, 2020, 5:40 PM Baregamyan notifications@github.com wrote:

Expected behaviour : I expect the focus frame to be clearly visible. I am using a dark theme and the black Alt-Tab window focus cycle frame is very hard to see in the dark theme. It is a torture and a huge waste of time trying to see which window is selected.

My problem is described here: https://forums.linuxmint.com/viewtopic.php?f=206&t=292655 I'd like to be able to change the frame color and width! Please help Alt-Tab between the windows and note the focus frame poor visibility. MATE general version: Linux Mint Mate 19.3. Package version Linux Distribution Link to downstream report of your Distribution

Dear Vistad. I have had the same problem! My fix: just update your Ubuntu 19.3 to 20.4 version. It really helps.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mate-desktop/marco/issues/614#issuecomment-640228972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWAM5UXJZR2HSP3YR2U6A3RVORFVANCNFSM4MRGWLBA .

[cdplayer]

FYI They/we are not using Ubuntu @vistad. Most seem to be using Linux Mint

[spvkgn]

It would be useful just to add a focus frame like in old 1.22:

New 1.24 version is much less usable:

[rogerdahl]

A quick and dirty fix for this is to force the color of the rectangle that is drawn for the selection. The code is in meta_select_image_draw(), in ./src/ui/tabpopup.c. I used something like color = (GdkRGBA) {1, 1, 0};. Changes can be tested with ./src/marco --replace, and installed semi-permanently with sudo make install. I can write up some better instructions if someone wants them.

Looking at the code, I can't say I fully understand why the color used by default is incorrect. There is an attempt to dynamically derive contrasting colors to use for things like the selection box in the alt-tab switcher, but this fails for dark themes, and fails worse the darker the theme is. It looks like the code was retrofitted to support dark themes at some point and some mistaken assumptions were made about which colors would be good to use as bases for the generated colors.

When using the setting in marco that cause the alt-tab switcher to outline the window that would be selected, the outline is drawn with completely white and black lines next to each other, which avoids the whole issue with color selection altogether, and is visible on any light or dark theme. It doesn't look very pretty, but could be a long term strategy for fixing the alt-tab selection without having to dive into the legacy reason for why it's broken.

Here's what it looks like with selection forced to blue and outline changed from white-black-white to white-red-white.

[sparkida]

Ubuntu Mate 20.04

Can be handled in theme's CSS

/* add to the bottom of your /usr/share/themes/<theme>/gtk-widgets.css */
.background.osd {
  background-color: green;
}

.osd image:selected {
  background: blue;
  border: 2px solid red;
  padding: 10px;
}

[vistad]

Hello guys, thank you for looking into this problem and offering a fix. Generally, it's been fixed in Linux Mint a few versions ago.

Best, Victor

On Sun, Jan 16, 2022 at 4:12 AM Nick Riley @.***> wrote:

Ubuntu Mate 20.04

Can be handled in theme's CSS

/ add to the bottom of your /usr/share/themes//gtk-widgets.css / .background.osd { background-color: green; }

.osd image:selected { background: blue; border: 2px solid red; padding: 10px; }

[image: shot] https://user-images.githubusercontent.com/3671173/149643310-cc9df866-b69c-49be-b89d-dd33384d55b0.png

— Reply to this email directly, view it on GitHub https://github.com/mate-desktop/marco/issues/614#issuecomment-1013786873, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWAM5XGO4OOT53S7USS5DLUWILOFANCNFSM4MRGWLBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>