compositor-xrender.c: keep tooltips visible in hidpi.

mtwebster commented 4 years ago

Make sure tooltips are visible when the source widget is close to the edge of the work area. widget is close to the edge of the work area.

See inline comments - as of 3.24 tooltip positioning is handled differently, and under certain conditions in hidpi, tooltips for the bottom panel applets can end up off the bottom of the work area.

To reproduce, in hidpi, set the bottom panel to approximately 30px tall and try to activate a tooltip for an applet on that panel.

I'm not too familiar with this compositor, it's possible there's a better place for this sort of fix.
I had assumed that since panels can be added to any monitor that I could get the precise work area for any monitor (not just for the primary) but that doesn't seem to be possible - tooltips will overlap the panel on a second monitor.

muktupavels commented 4 years ago

Sounds like something that should be fixed in GTK...

lukefromdc commented 3 years ago

Any updates on this?

raveit65 commented 3 years ago

@vkareh Can you please do a review? It runs fine since half a year at fedora stable all branches. @lukefromdc No idea why Linuxmint head and Mate founder (Clement Lefebvre) do not review his own developer from LM. Any way, i am fine with merging it, because i didn't get any bugreport at RedHat Bugzilla with that commit.

lukefromdc commented 3 years ago

Should I wait to see if that review comes in or proceed to merge this?

mate-desktop / marco

compositor-xrender.c: keep tooltips visible in hidpi. #625