search

mate-desktop / marco

MATE default window manager
https://mate-desktop.org
GNU General Public License v2.0
199 stars 87 forks source link

Fix implicit conversion changes signedness: 'gboolean' to 'guint' #712

Closed rbuj closed 2 years ago

rbuj commented 2 years ago 
CFLAGS="-Wconversion -Wunused-macros -Wunused-parameter" CC=clang ./autogen.sh --prefix=/usr --enable-debug --enable-compile-warnings=maximum && make &> make.log
core/constraints.c:631:5: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
    meta_rectangle_contained_in_region (info->usable_screen_region,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
core/constraints.c:644:5: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
    meta_rectangle_contained_in_region (info->usable_xinerama_region,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
core/constraints.c:663:9: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        meta_rectangle_overlaps_with_region (info->usable_screen_region,
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
core/display.c:3626:22: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                     meta_window_grab_all_keys (window, timestamp);
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
core/display.c:3630:22: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                     meta_screen_grab_all_keys (screen, timestamp);
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
core/display.c:3671:32: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
  display->grab_frame_action = frame_action;
                             ~ ^~~~~~~~~~~~
--
core/edge-resistance.c:1164:53: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'unsigned int' [-Wsign-conversion]
  window->display->grab_last_user_action_was_snap = snap;
                                                  ~ ^~~~
core/edge-resistance.c:1262:53: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'unsigned int' [-Wsign-conversion]
  window->display->grab_last_user_action_was_snap = snap;
                                                  ~ ^~~~
--
core/window-props.c:554:39: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
  window->using_net_wm_visible_name = modified;
                                    ~ ^~~~~~~~
--
core/window-props.c:625:44: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
  window->using_net_wm_visible_icon_name = modified;
                                         ~ ^~~~~~~~
--
core/window-props.c:822:40: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
          window->mwm_has_close_func = toggle_value;
                                     ~ ^~~~~~~~~~~~
core/window-props.c:828:43: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
          window->mwm_has_minimize_func = toggle_value;
                                        ~ ^~~~~~~~~~~~
core/window-props.c:834:43: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
          window->mwm_has_maximize_func = toggle_value;
                                        ~ ^~~~~~~~~~~~
core/window-props.c:840:39: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
          window->mwm_has_move_func = toggle_value;
                                    ~ ^~~~~~~~~~~~
core/window-props.c:846:41: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
          window->mwm_has_resize_func = toggle_value;
                                      ~ ^~~~~~~~~~~~
--
core/window.c:435:23: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
  window->has_shape = has_shape;
                    ~ ^~~~~~~~~
--
ui/theme-parser.c:1066:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        info->layout->has_title = has_title_val;
                                ~ ^~~~~~~~~~~~~
ui/theme-parser.c:1069:40: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
          info->layout->hide_buttons = hide_buttons_val;
                                     ~ ^~~~~~~~~~~~~~~~
raveit65 commented 2 years ago

@rbuj Can you please push PR to get a deployment?

rbuj commented 2 years ago

done

raveit65 commented 2 years ago

I can confirm that PR fixes the warnings, now i will test all the marco PRs a while. But those PRs needs to be reviewed by more people, ihmo.

mbkma commented 2 years ago

you could probably convert some types to a gboolean type instead (for example grab_last_user_action_was_snap could be a gboolean), but I think either way is fine.

rbuj commented 2 years ago

defining structures with bit fields helps to reduce memory consumption.

mbkma commented 2 years ago

ok, but in the case of grab_last_user_action_was_snap (which is defined in struct _MetaDisplay which is not a bit field) we have an unsigned int which uses as much memory as a gboolean which is a typedef of gint which is a typedef of int.

rbuj commented 2 years ago

Yes, signed and unsigned integers have the same size. Being a two-state variable we can say that everything other than zero is TRUE, otherwise is FALSE.

[robert@fedora ~]$ cat size.c 
/* gcc -Wall `pkg-config --cflags --libs glib-2.0` size.c -o size */
#include <stdio.h>
#include <glib.h>

int main()
{
    printf("Size of unsigned int : %ld byte(s)\n", sizeof(unsigned int));
    printf("Size of gboolean : %ld byte(s)\n", sizeof(gboolean));
    printf("Size of int : %ld byte(s)\n", sizeof(int));
    return 0;
}
[robert@fedora ~]$ gcc -Wall `pkg-config --cflags --libs glib-2.0` size.c -o size
[robert@fedora ~]$ ./size 
Size of unsigned int : 4 byte(s)
Size of gboolean : 4 byte(s)
Size of int : 4 byte(s)
glib/gmacros.h:#define  FALSE   (0)
glib/gmacros.h:#define  TRUE    (!FALSE)
rbuj commented 2 years ago

done

diff --git a/src/core/display-private.h b/src/core/display-private.h
index 0352c2a..332327e 100644
--- a/src/core/display-private.h
+++ b/src/core/display-private.h
@@ -177,6 +177,7 @@ struct _MetaDisplay {
        guint       grab_wireframe_active : 1;
        guint       grab_was_cancelled : 1;    /* Only used in wireframe mode */
        guint       grab_frame_action : 1;
+       guint       grab_last_user_action_was_snap : 1;
        MetaRectangle grab_wireframe_rect;
        MetaRectangle grab_wireframe_last_xor_rect;
        MetaRectangle grab_initial_window_pos;
@@ -189,7 +190,6 @@ struct _MetaDisplay {
        int         grab_wireframe_last_display_height;
        GList*      grab_old_window_stacking;
        MetaEdgeResistanceData* grab_edge_resistance_data;
-       unsigned int grab_last_user_action_was_snap;

        /* we use property updates as sentinels for certain window focus events
         * to avoid some race conditions on EnterNotify events
diff --git a/src/core/window.c b/src/core/window.c
index fb84085..8e15bed 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -7298,7 +7298,7 @@ update_move_timeout (gpointer data)
   MetaWindow *window = data;

   update_move (window,
-               window->display->grab_last_user_action_was_snap,
+               window->display->grab_last_user_action_was_snap != FALSE,
                window->display->grab_latest_motion_x,
                window->display->grab_latest_motion_y);

@@ -7604,7 +7604,7 @@ update_resize_timeout (gpointer data)
   MetaWindow *window = data;

   update_resize (window,
-                 window->display->grab_last_user_action_was_snap,
+                 window->display->grab_last_user_action_was_snap != FALSE,
                  window->display->grab_latest_motion_x,
                  window->display->grab_latest_motion_y,
                  TRUE);
@@ -7968,7 +7968,7 @@ meta_window_handle_mouse_grab_op_event (MetaWindow *window,
         case META_GRAB_OP_KEYBOARD_RESIZING_NW:
           /* no pointer round trip here, to keep in sync */
           update_resize (window,
-                         window->display->grab_last_user_action_was_snap,
+                         window->display->grab_last_user_action_was_snap != FALSE,
                          window->display->grab_latest_motion_x,
                          window->display->grab_latest_motion_y,
                          TRUE);
@@ -7991,7 +7991,7 @@ meta_window_handle_mouse_grab_op_event (MetaWindow *window,
        * mouse button and they almost certainly do not want a
        * non-snapped movement to occur from the button release.
        */
-      if (!window->display->grab_last_user_action_was_snap)
+      if (window->display->grab_last_user_action_was_snap == FALSE)
         {
           if (meta_grab_op_is_moving (window->display->grab_op))
             {
rbuj commented 2 years ago

grab_threshold_movement_reached could also be a bit field.

diff --git a/src/core/display-private.h b/src/core/display-private.h
index 332327e..0fd040c 100644
--- a/src/core/display-private.h
+++ b/src/core/display-private.h
@@ -178,11 +178,12 @@ struct _MetaDisplay {
        guint       grab_was_cancelled : 1;    /* Only used in wireframe mode */
        guint       grab_frame_action : 1;
        guint       grab_last_user_action_was_snap : 1;
+       guint       grab_threshold_movement_reached : 1;
        MetaRectangle grab_wireframe_rect;
        MetaRectangle grab_wireframe_last_xor_rect;
        MetaRectangle grab_initial_window_pos;
        int         grab_initial_x, grab_initial_y;  /* These are only relevant for */
-       gboolean    grab_threshold_movement_reached; /* raise_on_click == FALSE.    */
+                                                    /* raise_on_click == FALSE.    */
        MetaResizePopup* grab_resize_popup;
        gint64      grab_last_moveresize_time;
        guint32     grab_motion_notify_time;
diff --git a/src/core/display.c b/src/core/display.c
index ee6ccce..a4c2266 100644
--- a/src/core/display.c
+++ b/src/core/display.c
@@ -3855,7 +3855,7 @@ meta_display_end_grab_op (MetaDisplay *display,
        * For raise on click mode, the window was raised at the
        * beginning of the grab_op.
        */
-      if (!display->grab_threshold_movement_reached)
+      if (display->grab_threshold_movement_reached == FALSE)
         meta_window_raise (display->grab_window);
     }

@@ -3979,7 +3979,7 @@ meta_display_check_threshold_reached (MetaDisplay *display,
 {
   /* Don't bother doing the check again if we've already reached the threshold */
   if (meta_prefs_get_raise_on_click () ||
-      display->grab_threshold_movement_reached)
+      display->grab_threshold_movement_reached != FALSE)
     return;

   if (ABS (display->grab_initial_x - x) >= 8 ||
raveit65 commented 2 years ago

@mbkma Are your concerns solved?

mbkma commented 2 years ago

@rbuj I do not understand why this is a good way to fix the conversion warning. From docs of gboolean:

Never directly compare the contents of a gboolean variable with the values TRUE or FALSE. Use if (condition) to check a gboolean is "true", instead of if (condition == TRUE). Likewise use if (!condition) to check a gboolean is "false".

There is no validation when assigning to a gboolean variable and so it could contain any value represented by a gint. This is why the use of if (condition) is recommended. All non-zero values in C evaluate to "true".

In the code you assign a gboolean aka gint to a bit field aka guint : 1, e.g. window->using_net_wm_visible_icon_name = modified If you want to fix the conversion warning why not do an window->using_net_wm_visible_icon_name = (guint) modified instead of window->using_net_wm_visible_icon_name = (modified != FALSE) which is discouraged in the documentation if I understand it correctly?

rbuj commented 2 years ago

using_net_wm_visible_icon_name isn't a gboolean. In C, everything other than zero is true, otherwise is FALSE, and FALSE is equal to 0 in C. guint and guint : 1 have different sizes, so you can't do window->using_net_wm_visible_icon_name = (guint) modified.

glib doc recommends to not use (condition == TRUE), because TRUE is equal to 1, and any integer other than 0 is true in C, so you are removing valid values from the condition (..., -2,-1, 2, 3, 4, ...)

There are other programmers that use the ternary assignment for setting guint : 1, which is also valid.

window->using_net_wm_visible_icon_name = modified ? 1 : 0;
rbuj commented 2 years ago

To follow the recommendation of the glib documentation the following occurrences should be reviewed, and removing == TRUE from the condition should be enough...

$ grep -R -e "== TRUE" -e "TRUE ==" --include=*.c
mate-desktop/libmate-desktop/mate-colorsel.c:  if (priv->has_palette == TRUE)
mate-desktop/libmate-desktop/mate-desktop-thumbnail.c:      if (g_str_has_prefix (thumb->path, thumbnailer_dir) == TRUE)
mate-desktop/mate-about/mate-about.c:    if (mate_about_nogui == TRUE)
mate-session-manager/mate-session/gsm-manager.c:        if (schema_exists == TRUE)
mate-session-manager/mate-session/main.c:       if (autostart == TRUE)
mate-session-manager/mate-session/msm-gnome.c:  if (gnome_compat_started == TRUE)
atril/backend/comics/comics-document.c:     g_return_if_fail (success == TRUE);
atril/backend/comics/comics-document.c:     g_return_val_if_fail (success == TRUE, NULL);
atril/backend/epub/epub-document.c:            if ( xml_check_attribute_value(topchild,attributename,attributevalue) == TRUE )
atril/backend/epub/epub-document.c:            if ( xml_check_attribute_value(child,attributename,attributevalue) == TRUE )
atril/libdocument/ev-document.c:                if (document->iswebdocument == TRUE ) {
atril/libdocument/ev-document.c:    if (document->iswebdocument == TRUE ) {
atril/libview/ev-jobs.c:    if ( job->document->iswebdocument == TRUE )
atril/libview/ev-jobs.c:    if (job->document->iswebdocument == TRUE ) {
atril/libview/ev-jobs.c:    if (job->document->iswebdocument == TRUE) {
atril/libview/ev-view.c:    if (view->jump_to_find_result == TRUE) {
atril/libview/ev-web-view.c:    if (ev_document_model_get_inverted_colors(model) == TRUE) {
atril/libview/ev-web-view.c:        if (webview->search->search_jump == TRUE) {
atril/shell/ev-sidebar-thumbnails.c:    if (priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:            if (window->priv->document && window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (document->iswebdocument == TRUE &&
atril/shell/ev-window.c:    } else if ( EV_WINDOW_IS_PRESENTATION (ev_window) && document->iswebdocument == TRUE )
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE)
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE)
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) return ;
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) return ;
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) return ;
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (ev_window->priv->document && ev_window->priv->document->iswebdocument == TRUE ) {
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE )  {
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE ) return;
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE ) return;
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE ) return;
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE ) return;
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE ) return;
atril/shell/ev-window.c:    if (window->priv->document && window->priv->document->iswebdocument == TRUE ) return;
caja/eel/eel-self-checks.c:    if (boolean == TRUE)
caja/libcaja-private/caja-directory-async.c:    g_assert (unconfirmed == FALSE || unconfirmed == TRUE);
caja/libcaja-private/caja-extensions.c:    g_return_val_if_fail (retval == TRUE, FALSE);
caja/libcaja-private/caja-file-operations.c:        if ((!error) || (unmounted == TRUE)){
caja/libcaja-private/caja-file-utilities.c:     if (g_file_test(user_directory, G_FILE_TEST_IS_SYMLINK) == TRUE)
caja/libcaja-private/caja-file-utilities.c:     else if (g_file_test(user_directory, G_FILE_TEST_IS_DIR) == TRUE)
caja/libcaja-private/caja-file-utilities.c:     else if (g_file_test(user_directory, G_FILE_TEST_EXISTS) == TRUE)
caja/libcaja-private/caja-icon-canvas-item.c:    g_return_if_fail (show_stretch_handles == FALSE || show_stretch_handles == TRUE);
caja/libcaja-private/caja-icon-canvas-item.c:    g_return_if_fail (state == FALSE || state == TRUE);
caja/libcaja-private/caja-icon-container.c:    g_assert (select == FALSE || select == TRUE);
caja/libcaja-private/caja-icon-container.c:    g_assert (icon->is_selected == FALSE || icon->is_selected == TRUE);
caja/libcaja-private/caja-icon-container.c:    g_return_if_fail (auto_layout == FALSE || auto_layout == TRUE);
caja/libcaja-private/caja-icon-container.c:    g_return_if_fail (tighter_layout == FALSE || tighter_layout == TRUE);
caja/libcaja-private/caja-icon-container.c:    g_return_val_if_fail (start_flag == FALSE || start_flag == TRUE, FALSE);
caja/libcaja-private/caja-open-with-dialog.c:    if (gtk_expander_get_expanded (GTK_EXPANDER (expander)) == TRUE)
caja/src/file-manager/fm-directory-view.c:      if (g_file_test(nautilus_scripts_path, G_FILE_TEST_IS_DIR) == TRUE)
caja/src/file-manager/fm-tree-model.c:    g_return_if_fail (show_hidden_files == FALSE || show_hidden_files == TRUE);
caja/src/file-manager/fm-tree-model.c:    g_return_if_fail (show_only_directories == FALSE || show_only_directories == TRUE);
caja-extensions/sendto/caja-sendto-command.c:       if (matches == TRUE && cur_char != '\0') {
caja-dropbox/src/caja-dropbox.c:    ((isdir == TRUE &&
caja-dropbox/src/dropbox-client.c:  if (dropbox_client_is_connected(dc) == TRUE) {
caja-dropbox/src/dropbox-command-client.c:  if (dropbox_command_client_is_connected(dcc) == TRUE) {
engrampa/src/java-utils.c:          if (prev_char_is_bslash == TRUE) {
engrampa/src/java-utils.c:          if (prev_char_is_bslash == TRUE)
eom/src/eom-image.c:    if ((new_frame = gdk_pixbuf_animation_iter_advance (img->priv->anim_iter, NULL)) == TRUE) {
eom/src/eom-scroll-view.c:      if (eom_image_is_animation (image) == TRUE ) {
eom/src/eom-window.c:   if (handle_selection == TRUE && result == FALSE) {
libmatemixer/backends/alsa/alsa-backend.c:    if (read_device (alsa, "default") == TRUE)
libmatemixer/backends/alsa/alsa-backend.c:        if (read_device (alsa, card) == TRUE)
libmatemixer/backends/alsa/alsa-backend.c:    if (added == TRUE) {
libmatemixer/backends/alsa/alsa-backend.c:    if (g_hash_table_contains (alsa->priv->devices_ids, id) == TRUE) {
libmatemixer/backends/alsa/alsa-backend.c:    if (alsa_device_is_open (device) == TRUE)
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_has_controls_or_switches (device->priv->input) == TRUE) {
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_has_controls_or_switches (device->priv->output) == TRUE) {
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_has_controls_or_switches (device->priv->input) == TRUE)
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_has_controls_or_switches (device->priv->output) == TRUE)
libmatemixer/backends/alsa/alsa-device.c:    if (add_stream == TRUE) {
libmatemixer/backends/alsa/alsa-device.c:            if (cenum == TRUE)
libmatemixer/backends/alsa/alsa-device.c:        if (cvolume == TRUE)
libmatemixer/backends/alsa/alsa-device.c:        if (pvolume == TRUE)
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_remove_elements (device->priv->input, name) == TRUE) {
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_remove_elements (device->priv->output, name) == TRUE) {
libmatemixer/backends/alsa/alsa-device.c:        while (device->priv->events_pending == TRUE)
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_has_controls (device->priv->input) == TRUE) {
libmatemixer/backends/alsa/alsa-device.c:    if (alsa_stream_has_controls (device->priv->output) == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:        if (data->switch_usable == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:            if (data->channels == 1 || data->switch_joined == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:            if (data->active == TRUE)
libmatemixer/backends/alsa/alsa-stream-control.c:        if (data->active == TRUE)
libmatemixer/backends/alsa/alsa-stream-control.c:    if (control->priv->data.switch_joined == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:    if (change == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:    if (control->priv->data.volume_joined == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:    if (change == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:    if (control->priv->data.volume_joined == TRUE)
libmatemixer/backends/alsa/alsa-stream-control.c:        if (lc == TRUE || rc == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:            if (lc == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:                                           volume) == TRUE)
libmatemixer/backends/alsa/alsa-stream-control.c:        if (fc == TRUE || bc == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:            if (fc == TRUE) {
libmatemixer/backends/alsa/alsa-stream-control.c:                                           volume) == TRUE)
libmatemixer/backends/alsa/alsa-stream-input-control.c:    if (data->switch_usable == TRUE)
libmatemixer/backends/alsa/alsa-stream-input-control.c:        if (data->switch_usable == TRUE) {
libmatemixer/backends/alsa/alsa-stream-input-control.c:            if (data->switch_usable == TRUE) {
libmatemixer/backends/alsa/alsa-stream-output-control.c:    if (data->switch_usable == TRUE)
libmatemixer/backends/alsa/alsa-stream-output-control.c:        if (data->switch_usable == TRUE) {
libmatemixer/backends/alsa/alsa-stream-output-control.c:            if (data->switch_usable == TRUE) {
libmatemixer/backends/oss/oss-device.c:    if (oss_stream_has_controls (device->priv->input) == TRUE) {
libmatemixer/backends/oss/oss-device.c:    if (oss_stream_has_controls (device->priv->output) == TRUE) {
libmatemixer/backends/oss/oss-device.c:            if (OSS_MASK_HAS_DEVICE (device->priv->recmask, i) == TRUE)
libmatemixer/backends/oss/oss-device.c:    if (device->priv->poll_use_counter == TRUE) {
libmatemixer/backends/oss/oss-device.c:    if (load == TRUE) {
libmatemixer/backends/oss/oss-device.c:        if (device->priv->poll_use_counter == TRUE &&
libmatemixer/backends/oss/oss-stream-control.c:    if (stereo == TRUE)
libmatemixer/backends/oss/oss-stream-control.c:    return (OSS_STREAM_CONTROL (mmsc)->priv->stereo == TRUE) ? 2 : 1;
libmatemixer/backends/oss/oss-stream-control.c:    if (control->priv->stereo == TRUE)
libmatemixer/backends/oss/oss-stream-control.c:    if (control->priv->stereo == TRUE) {
libmatemixer/backends/oss/oss-stream-control.c:    if (control->priv->stereo == TRUE) {
libmatemixer/backends/oss/oss-stream-control.c:        return OSS_STREAM_CONTROL (mmsc)->priv->stereo == TRUE;
libmatemixer/backends/oss/oss-stream-control.c:    if (control->priv->stereo == TRUE) {
libmatemixer/backends/oss/oss-backend.c:        if (added_current == TRUE)
libmatemixer/backends/oss/oss-backend.c:    if (added == TRUE) {
libmatemixer/backends/oss/oss-backend.c:    if (g_hash_table_contains (oss->priv->devices_paths, path) == TRUE) {
libmatemixer/backends/oss/oss-backend.c:        if (*added == TRUE)
libmatemixer/backends/oss/oss-backend.c:    if (oss_device_is_open (device) == TRUE)
libmatemixer/backends/pulse/pulse-backend.c:        if (pulse->priv->connected_once == TRUE) {
libmatemixer/backends/pulse/pulse-backend.c:    if (pulse_sink_add_input (sink, info) == TRUE)
libmatemixer/backends/pulse/pulse-backend.c:    if (pulse_source_add_output (source, info) == TRUE)
libmatemixer/backends/pulse/pulse-backend.c:    while (g_hash_table_iter_next (&iter, NULL, &ext) == TRUE)
libmatemixer/backends/pulse/pulse-backend.c:    while (g_hash_table_iter_next (&iter, &name, &ext) == TRUE) {
libmatemixer/backends/pulse/pulse-backend.c:    if (pulse_connection_connect (pulse->priv->connection, TRUE) == TRUE) {
libmatemixer/backends/pulse/pulse-connection.c:    if (wait_for_daemon == TRUE)
libmatemixer/backends/pulse/pulse-connection.c:    if (connection->priv->ext_streams_loading == TRUE) {
libmatemixer/backends/pulse/pulse-connection.c:        if (process_pulse_operation (connection, op) == TRUE) {
libmatemixer/backends/pulse/pulse-connection.c:        if (connection->priv->ext_streams_dirty == TRUE)
libmatemixer/backends/pulse/pulse-ext-stream.c:    if (volume_changed == TRUE)
libmatemixer/backends/pulse/pulse-stream-control.c:    if (take == TRUE)
libmatemixer/backends/pulse/pulse-stream-control.c:    if (enabled == TRUE) {
libmatemixer/examples/monitor.c:    if (debug == TRUE)
libmatemixer/libmatemixer/matemixer-backend-module.c:    if (module->priv->loaded == TRUE) {
libmatemixer/libmatemixer/matemixer-backend-module.c:    g_return_val_if_fail (module->priv->loaded == TRUE, NULL);
libmatemixer/libmatemixer/matemixer-backend-module.c:    if (module->priv->loaded == TRUE)
libmatemixer/libmatemixer/matemixer-stream-toggle.c:    if (state == TRUE)
libmatemixer/libmatemixer/matemixer-stream-toggle.c:    if (state == TRUE)
libmatemixer/libmatemixer/matemixer.c:    if (initialized == TRUE)
libmatemixer/libmatemixer/matemixer.c:    if (loaded == TRUE)
libmatemixer/libmatemixer/matemixer.c:    if (G_LIKELY (g_module_supported () == TRUE)) {
marco/src/core/testboxes.c:                meta_rectangle_could_fit_rect (&temp1, &temp2) == TRUE);
marco/src/core/testboxes.c:                meta_rectangle_could_fit_rect (&temp2, &temp1) == TRUE);
marco/src/core/testboxes.c:                meta_rectangle_could_fit_in_region (region, &rect) == TRUE);
marco/src/core/testboxes.c:      g_assert (meta_rectangle_could_fit_in_region (region, &rect) == TRUE);
marco/src/core/testboxes.c:          g_assert (meta_rectangle_contained_in_region (region, &rect) == TRUE);
marco/src/core/window.c:  if ( ((window->net_wm_user_time_set == TRUE) &&
marco/src/core/window.c:       ((window->initial_timestamp_set == TRUE) &&
mate-applets/geyes/src/geyes.c:    if ((result = properties_load (eyes_applet)) == TRUE)
mate-applets/geyes/src/themes.c:    if (themes_created == TRUE)
mate-applets/mateweather/src/mateweather-pref.c:    if (toggled == FALSE || gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON (pref->priv->basic_radar_url_btn)) == TRUE)
mate-control-center/capplets/about-me/mate-about-me.c:      if (g_file_set_contents (file, (gchar *)data, length, &error) == TRUE) {
mate-control-center/capplets/appearance/appearance-desktop.c:  if (item->deleted == TRUE)
mate-control-center/capplets/appearance/appearance-desktop.c:      if (item->deleted == TRUE)
mate-control-center/capplets/appearance/appearance-desktop.c:    if (item->deleted == TRUE)
mate-control-center/capplets/time-admin/src/main.c:    if(ProcessRuning() == TRUE)
mate-control-center/libslab/app-shell.c:    if (TRUE == filtered_out_everything)
mate-media/mate-volume-control/dialog-main.c:        if (destroy == TRUE)
mate-media/mate-volume-control/dialog-main.c:        if (destroy == TRUE)
mate-media/mate-volume-control/dialog-main.c:        if (show_version == TRUE) {
mate-media/mate-volume-control/dialog-main.c:        if (debug == TRUE) {
mate-media/mate-volume-control/gvc-applet.c:                if (show == TRUE)
mate-media/mate-volume-control/gvc-applet.c:        if (G_UNLIKELY (applet->priv->running == TRUE))
mate-media/mate-volume-control/gvc-channel-bar.c:        if (bar->priv->control == NULL || bar->priv->click_lock == TRUE)
mate-media/mate-volume-control/gvc-channel-bar.c:        if (set_lower == TRUE)
mate-media/mate-volume-control/gvc-channel-bar.c:        if (bar->priv->show_mute == TRUE) {
mate-media/mate-volume-control/gvc-channel-bar.c:                if (enable == TRUE) {
mate-media/mate-volume-control/gvc-channel-bar.c:                if (mate_mixer_stream_control_get_mute (bar->priv->control) == TRUE) {
mate-media/mate-volume-control/gvc-channel-bar.c:        if (bar->priv->click_lock == TRUE) {
mate-media/mate-volume-control/gvc-channel-bar.c:        if (bar->priv->show_mute == TRUE) {
mate-media/mate-volume-control/gvc-channel-bar.c:        if (bar->priv->show_icons == TRUE) {
mate-media/mate-volume-control/gvc-combo-box.c:                if (symmetric == TRUE)
mate-media/mate-volume-control/gvc-combo-box.c:        while (cont == TRUE) {
mate-media/mate-volume-control/gvc-mixer-dialog.c:        if (has_settings == TRUE)
mate-media/mate-volume-control/gvc-mixer-dialog.c:        if (mate_mixer_stream_control_get_mute (control) == TRUE)
mate-media/mate-volume-control/gvc-mixer-dialog.c:        if (use_size_group == TRUE)
mate-media/mate-volume-control/gvc-mixer-dialog.c:                                    &iter) == TRUE)
mate-media/mate-volume-control/gvc-mixer-dialog.c:                                    &iter) == TRUE)
mate-media/mate-volume-control/gvc-mixer-dialog.c:                if (show_button == TRUE)
mate-media/mate-volume-control/gvc-mixer-dialog.c:                                    &iter) == TRUE)
mate-media/mate-volume-control/gvc-status-icon.c:                if (show == TRUE)
mate-media/mate-volume-control/gvc-status-icon.c:        if (G_UNLIKELY (status_icon->priv->running == TRUE))
mate-media/mate-volume-control/status-icon-main.c:        if (show_version == TRUE) {
mate-media/mate-volume-control/status-icon-main.c:        if (debug == TRUE) {
mate-panel/applets/notification_area/main.c:  if (g_settings_get_boolean (settings, "enable-sni-support") == TRUE)
mate-panel/mate-panel/libpanel-util/panel-launch.c: if ((local_error == NULL) && (retval == TRUE))
mate-panel/mate-panel/libpanel-util/panel-launch.c:        if (local_error == NULL && retval == TRUE) {
mate-panel/mate-panel/main.c:   if (reset == TRUE)
mate-panel/mate-panel/main.c:   if (run_dialog == TRUE)
mate-panel/mate-panel/panel-config-global.c:    g_assert (global_config_initialised == TRUE);
mate-panel/mate-panel/panel-config-global.c:    g_assert (global_config_initialised == TRUE);
mate-panel/mate-panel/panel-config-global.c:    g_assert (global_config_initialised == TRUE);
mate-panel/mate-panel/panel-config-global.c:    g_assert (global_config_initialised == TRUE);
mate-panel/mate-panel/panel-config-global.c:    g_assert (global_config_initialised == TRUE);
mate-power-manager/src/gpm-idle.c:  egg_test_assert (test, (idle->priv->x_idle == TRUE));
mate-power-manager/src/gpm-idle.c:  egg_test_assert (test, (idle->priv->x_idle == TRUE));
mate-power-manager/src/gpm-idle.c:  egg_test_assert (test, (idle->priv->x_idle == TRUE));
mate-screensaver/src/gs-debug.c:    if (debugging == TRUE)
mate-terminal/src/terminal-options.c:       if (iw->force_menubar_state && iw->menubar_state == TRUE)
mate-terminal/src/terminal-screen.c:    if (schema_exists == TRUE) {
mate-utils/baobab/src/baobab.c: if (busy == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c: if (gsearch->command_details->is_command_timeout_enabled == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c: if (gtk_expander_get_expanded (GTK_EXPANDER (object)) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c:     if (result == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c:             if (result == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c: if (GTK_IS_MENU (gsearch->search_results_popup_menu) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c: if (GTK_IS_MENU (gsearch->search_results_popup_submenu) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c: if (file == NULL || g_file_test (file, G_FILE_TEST_IS_DIR) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c:         file = g_strdup (((show_app_list == TRUE) ? locale_file_first : NULL));
mate-utils/gsearchtool/src/gsearchtool-callbacks.c:     if (gsearch->is_search_results_single_click_to_activate == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-callbacks.c:         if (gtk_tree_model_iter_nth_child (GTK_TREE_MODEL (store), &iter, NULL, idx) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-support.c:   if ((strlen (dir) > 1) && (g_str_has_suffix (dir, G_DIR_SEPARATOR_S) == TRUE)) {
mate-utils/gsearchtool/src/gsearchtool-support.c:               if (g_pattern_match_simple (dir, path) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-support.c:   if ((strlen (dir) > 1) && (g_str_has_suffix (dir, G_DIR_SEPARATOR_S) == TRUE)) {
mate-utils/gsearchtool/src/gsearchtool-support.c:               if (g_pattern_match_simple (dir, path) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-support.c:   if (content_type == NULL || g_content_type_is_unknown (content_type) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-support.c:   if (g_file_info_get_is_symlink (file_info) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-support.c:   if (gsearch->show_thumbnails == TRUE) {
mate-utils/gsearchtool/src/gsearchtool-support.c:   if (g_file_test (file, G_FILE_TEST_IS_DIR) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:           if (broken_pipe == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (!(condition & G_IO_IN) || broken_pipe == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (case_insensitive_arguments_initialized == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:       if (gsearch->is_locate_database_available == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (first_pass == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (GTK_IS_MENU_ITEM (gsearch->search_results_save_results_as_item) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (gsearch->command_details->is_command_first_pass == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:       if (gsearch->command_details->is_command_first_pass == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:               && (gsearch->is_locate_database_available == TRUE)
mate-utils/gsearchtool/src/gsearchtool.c:   if (g_hash_table_lookup_extended (gsearch->search_results_filename_hash_table, file, NULL, NULL) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:       if (g_str_has_suffix (look_in_folder, G_DIR_SEPARATOR_S) == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:           if (broken_pipe == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:                                 is_path_hidden (gsearch->command_details->look_in_folder_string) == TRUE) &&
mate-utils/gsearchtool/src/gsearchtool.c:   if (!(condition & G_IO_IN) || broken_pipe == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:            && (gsearch->command_details->is_command_using_quick_mode == TRUE)
mate-utils/gsearchtool/src/gsearchtool.c:            && (gsearch->command_details->is_command_first_pass == TRUE)
mate-utils/gsearchtool/src/gsearchtool.c:            && (gsearch->command_details->is_command_second_pass_enabled == TRUE)
mate-utils/gsearchtool/src/gsearchtool.c:           if (broken_pipe == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (!(condition & G_IO_IN) || broken_pipe == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:                    (is_second_scan_excluded_path (gsearch->command_details->look_in_folder_string) == TRUE)) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (gsearch->command_details->is_command_first_pass == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (gsearch->is_search_results_single_click_to_activate == TRUE) {
mate-utils/gsearchtool/src/gsearchtool.c:   if (gsearch->is_window_maximized == TRUE) {
mate-utils/logview/src/logview-log.c:    } while (res == TRUE && bytes_read > 0);
mate-utils/mate-dictionary/libgdict/gdict-defbox.c:  return (defbox->priv->show_find == TRUE);
pluma/pluma/pluma-commands-file.c:                              PLUMA_IS_CLOSING_TAB)) == TRUE)
pluma/pluma/pluma-document-loader.c:     * (when completed == TRUE), so we need to prevent finalization.
pluma/pluma/pluma-smart-charset-converter.c:    if (ret == TRUE && !g_utf8_validate (out, nwritten, NULL))
pluma/tests/document-output-stream.c:   g_assert(g_output_stream_flush (out, NULL, &err) == TRUE);