search

mate-desktop / marco

MATE default window manager
https://mate-desktop.org
GNU General Public License v2.0
192 stars 85 forks source link

replace _NET_WM_PID with XResGetClientPid #741

Closed lambdanil closed 1 year ago

lambdanil commented 1 year ago

This patch adresses this issue https://github.com/mate-desktop/marco/issues/301 tested and works well with flapak.

muktupavels commented 1 year ago

Did you copy that code from metacity?

lambdanil commented 1 year ago

Did you copy that code from metacity?

yes

raveit65 commented 1 year ago

Did you copy that code from metacity?

Something wrong with the code?

raveit65 commented 1 year ago

Commit history is really meaningless. Origin commit is from metacity and called 

 window-props: use XResQueryClientIds to get pid

_NET_WM_PID is unreliable! It can be faked or pid might be from
different namespace. Ignore _NET_WM_PID and use XResQueryClientIds
to get pid.

https://gitlab.gnome.org/GNOME/metacity/-/commit/bcbe966511362a8eb8c8c64035ab160086c931f8

I think one of your commits should name like this, with minimum a link to origin commit in commit body. Or you should use naming and date from original author.

Without a good meaningful name what commit does i can't squash_all_commits_in_one + merge your PR.

raveit65 commented 1 year ago

Beside from my concerns the run as super user info is gone.

lambdanil commented 1 year ago

The "(as superuser)" is still there

Here is before the commit: Snímek obrazovky z 2022-11-06 20-26-02 You can see OBS and Spotify both show (as superuser)

Now after the commit Snímek obrazovky z 2022-11-06 20-26-11 Caja still shows "(as superuser)", while Spotify and OBS no longer do.

raveit65 commented 1 year ago

@CuBeRJAN see https://github.com/mate-desktop/marco/issues/746 You PR breaks connecting a machine with marco-1.26.1 via x2go.

krotow commented 1 month ago

Your commit either got lost in translation or simply didn't landed in Ubuntu/Mint repos. "as superuser" is still present in Linux Mint 21.3 MATE. At least 3 fresh system installs with first time online updates. All Flatpak apps that are launched from user account, has "as superuser" in title.