search

mate-desktop / marco

MATE default window manager
https://mate-desktop.org
GNU General Public License v2.0
192 stars 85 forks source link

Fix losing title of windows with a 3 or 4 bytes first character #758

Closed cwendling closed 11 months ago

cwendling commented 11 months ago

Fixes #757.

cwendling commented 11 months ago

@lukefromdc it shouldn't change anything, but here I get proper characters (well, I see Chinese characters, and assume it's the right ones :)) and it works

raveit65 commented 11 months ago

@cloudfish Can you please test PR

raveit65 commented 11 months ago

I have no idea what's wrong with https://zh.wikipedia.org/ on my fedora system. Chinese symbols are in the middle of the window title. Without a screenshot from reporter i would say it's debian specific :)

raveit65 commented 11 months ago

I can confirm now the issue, sadly the bad commit is in latest 1.26. release. I will test PR, but without a clear confirmation for PR from someone who use Chinese symbols, i don't like to do a new release for one commit to avoid breaking stable 1.26 branch again.

cwendling commented 11 months ago

@raveit65 hopefully @cloudfish will be able to test, but this is a very simple fix I am confident in. If you confirm it fixes the Firefox example for you as well we should be good. A maybe more important test is whether it doesn't break #749 -- but my tests with KCalc tell me it doesn't -- and the logic I see agrees.

raveit65 commented 11 months ago

If it is urgent Debian maintainer can use it as patch for his build. Same what i do in fedora when it is urgent. I like to test things a while before they go in stable. Btw. everybody from the team can do new releases. This is not only in my hand ;)

cwendling commented 8 months ago

@mate-desktop/core-team can I cherry-pick this in 1.26? We have the breaking change there, and it's affecting distros that might or might not know about it.

cwendling commented 8 months ago

Cherry-picked as a938884530839152c9854dd0d8248b36c3c2e3fd