search

mate-desktop / mate-applets

Applets for use with the MATE panel
http://www.mate-desktop.org
GNU General Public License v2.0
79 stars 67 forks source link

Make the shrink label an option in netspeed #189

Open alejandro-perez opened 8 years ago

alejandro-perez commented 8 years ago

Sometimes, the netspeed applet takes too much space because either you decided to use shortened units, or any other reason. There is an internal variable that determines whether the labels should shrink or not. I have tweaked the source code so it always shrinks, and I'm happy with the result. Would it be possible to publish that option through dconf?

Regards

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/33968533-make-the-shrink-label-an-option-in-netspeed?utm_campaign=plugin&utm_content=tracker%2F517519&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F517519&utm_medium=issues&utm_source=github).
raveit65 commented 8 years ago

A PR is welcome to speed this up, .... we are a small team.

alejandro-perez commented 8 years ago

I took a look and didn't see an obvious way of doing it. I will nevertheless take a second round and try to contribute.

Bubu commented 8 years ago

I would be interested in this option/feature. This is what it looks like right now for me:

screenshot at 2016-07-20 15_11_01

Bubu commented 8 years ago

After rebooting the applet is now much narrower. I don't know what changed.

alejandro-perez commented 8 years ago

The "problem" with the applet is that it gets larger on demand (e.g when you have 100.24MB) but it never gets shrink again. So it will eventually get as large as the largest amount of info was displayed. Whwn you reboot (or start a new session) it starts with the minimal size.

r2rien commented 8 years ago

Hi, I am the author of the shortened units and icons display options I personally consider the behaviour of not expanding/shrinking perpetually as a feature. If it would be apart of the panel ugliness erratically moving, from my personal taste, all other applet relatively positioned against will move in concert, and this position change would break how expectable you made your panel, meaning where to point your mouse to interact with it. ..like in Bubu screen-shot, volume applet moving around could make it hard to toggle without toggling battery applet by mistake A workaround could be to position it as last, but personally again (as Bubu too apparently) for consistency I like it to be beside nm-applet So if you implement this, please make it optional As a rationale, it's true that it's pixel occupation could be improved, that was my intention with the shortened units and icon display options.. I think a better approach could be to limit the numbers displayed, you don't use netspeed for precision but to have a more rough idea In this way, there is already switches from B to K to M, maybe G is missing (thus 100.24MB ~> 0.1G ?), I don't remember... cheers

alejandro-perez commented 8 years ago

Hi r2rien,

I see you point, and I'd agree it is a feature. I never wanted to criticise, not for a moment. That's why I was asking for an option, not a behaviour change. In my personal case, I use to place netspeed as the last applet (left-most applet from the right-most corner). So, no other applet would be moving. I do prefer it to shrink because sometimes it ends up taken so much space that it leaves little space for the window list (right-most appliet from the left-most corner).

But again, I was asking for an option. Even an "obscure", d-conf onlhy, option. I don't think a menu option is even required.

Regards and good job!