mate-desktop / mate-applets

Applets for use with the MATE panel
http://www.mate-desktop.org
GNU General Public License v2.0
79 stars 67 forks source link

"icon file not found" icon shown for weather applet; tooltip is "broken clouds", at night #535

Open adrnde opened 3 years ago

adrnde commented 3 years ago

Expected behaviour

Should be showing partial cloud icon perhaps with a partial moon

Actual behaviour

showing rectangle with red slashed circle; temperature displayed correctly beneath Mouseover brings up city with "broken clouds" as expected

Steps to reproduce the behaviour

Weather Report 1.24.0, on fresh install of Linux Mint 20 Need "broken clouds" as weather. Switched to diff city with clear weather, shows moon sliver Trying different cities: overcast, shows two overlapping clouds mist shows wavy lines, as expected As of when trying this, Nov 6 02:00 EST, Trondheim, Norway also had 'broken clouds', and also displayed the broken icon

MATE general version

1.24.0

WeatherApp-Broken_Clouds

Package version

Mate-weather-app 1.24.0 Mate-panel 1.24.0

Linux Distribution

Linux Mint 20 WeatherApp-Broken_Clouds

Link to downstream report of your Distribution

lukefromdc commented 3 years ago

What icon theme are you using? We have a set of "weather-few-clouds" icons in the default mate icon theme which menta inherits from as well. Looking at the "weather.c" source file in libmateweather(where these icons are chosen) shows this block:


    case SKY_BROKEN:
    case SKY_SCATTERED:
    case SKY_FEW:
    if (daytime)
        return "weather-few-clouds";
    else {
        icon = g_stpcpy(icon_buffer, "weather-few-clouds-night");
        break;
    }

meaning the "weather-few-clouds" or "weather-few-clouds-night" icon which we provide should display unless you are using an icon theme that does not provide it and does not inherit from mate-or you have found a bug in libmateweather.

ssrublev commented 3 years ago

I've seen such problems with weather icons in Ubuntu-MATE, but not always: sometimes icon present, sometimes not

ssrublev commented 3 years ago

image

a picture of constantly missing icon in MATE systray (which is hardly broken in Ubuntu but works well in Fedora)

rbuj commented 3 years ago

@ssrublev the icon shown in your screenshot belongs to indicator-datetime.

adrnde commented 3 years ago

Tracking days when the weather icon works / does not, icons go missing at night under conditions of "few clouds" or "broken clouds".

It looks like the icon folder "Mint-X" is the one being used, and it does have an icon for weather-few-clouds-night.

On occasion the weather app will not update at all, instead just sitting in 'updating' status indefinitely. The text based "weather" from package "weather-util", which gets data from the same source, always works. Perhaps there is some fiddling detail in the received data that isn't always what is expected?

rbuj commented 3 years ago

@adrnde There may be several reasons which may prevent fetching weather data. If the command line application weather from weather-util package cannot get the weather data it uses a cache to display the last successfully captured data.

https://www.yuggoth.org/gitweb?p=weather.git;a=tree

The weather applet sets the "Updating..." tooltip just before updating the weather information: https://github.com/mate-desktop/mate-applets/blob/e712870484b3ae86d971133ecffc88f1793898fe/mateweather/mateweather-applet.c#L521

It's updated only if it's able to retrieve valid data: https://github.com/mate-desktop/mate-applets/blob/e712870484b3ae86d971133ecffc88f1793898fe/mateweather/mateweather-applet.c#L442

rbuj commented 3 years ago

It may be related to https://github.com/mate-desktop/libmateweather/pull/91