search

mate-desktop / mate-applets

Applets for use with the MATE panel
http://www.mate-desktop.org
GNU General Public License v2.0
79 stars 67 forks source link

WIP netspeed: remove ipv4 routing check #576

Closed rbuj closed 3 years ago

vkareh commented 3 years ago

What's the purpose of this? With your branch I lose a lot of information from my netspeed window:

rbuj commented 3 years ago

The get_default_route was added for selecting an interface with a gateway on startup. It's part of the legacy and It makes a lot of unnecessary calls to pull current device info. The network graph data is collected from network status snapshots, and these are taken periodically, so there is no need to add an extra snapshot on each iteration. I'll check it on baremetal for testing a wireless connection.

rbuj commented 3 years ago

@vkareh It worked fine on baremetal:

Screenshot at 2020-12-22 20-51-13

vkareh commented 3 years ago

My tests are all in baremetal. This still doesn't work for my default/wireless device.

vkareh commented 3 years ago

wait... poking around at it, the wireless device works, but it's no longer the default. For some reason your patch changes what my default interface is... ???

rbuj commented 3 years ago

Ok, the code is still used for setting the Default interface name. However, it only takes into account the ipv4 routing table.