netspeed: Add NetspeedPreferences class

raveit65 commented 3 years ago

Beside from this warning the applet runs fine and dialogs are looking like before.

lukefromdc commented 3 years ago

If that warning is cut and pasted we also have a (cosmetic) typo in the name of a function(destory)

On 1/3/2021 at 5:13 AM, "raveit65" notifications@github.com wrote:

@raveit65 commented on this pull request.

static void -device_change_cb (GtkComboBox *combo,

NetspeedApplet netspeed) +netspeed_applet_destory_preferences (GtkWidget widget,

gpointer user_data) {

New build warning.
netspeed.c:1072:49: warning: unused parameter 'widget' [-Wunused-
parameter]

netspeed_applet_destory_preferences (GtkWidget *widget,
https://travis-ci.org/github/mate-desktop/mate- applets/jobs/751446165#L6908

-- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate- applets/pull/581#pullrequestreview-560683865

rbuj commented 3 years ago

netspeed_applet_destory_preferences 😄

rbuj commented 3 years ago

@lukefromdc thank you very much for the find, PR #588

mate-desktop / mate-applets

netspeed: Add NetspeedPreferences class #581