mate-desktop / mate-applets

Applets for use with the MATE panel
http://www.mate-desktop.org
GNU General Public License v2.0
79 stars 67 forks source link

Add click-hide key to the stickynotes GSettings #628

Closed zhuyaliang closed 1 year ago

zhuyaliang commented 2 years ago

Add a new key value "click-hide",When this key is disabled, click the note icon on the panel, and the note will not be hidden Fix #627

test

  1. make PR and install
  2. replace note from panel
  3. run gsettings set org.mate.stickynotes click-hide false
  4. clicked note icon
rbuj commented 1 year ago

I think you just need to modify the stickynote_show_notes function. The code looks better and it's more readable.

static void
stickynote_show_notes (gboolean visible)
{
    StickyNote *note;
    GList *l;

    if (stickynotes->visible == visible)
        return;

    if (g_settings_get_boolean (stickynotes->settings, "click-hide") && !visible)
        return;

    stickynotes->visible = visible;

    for (l = stickynotes->notes; l; l = l->next) {
        note = l->data;
        stickynote_set_visible (note, visible);
    }
}
lukefromdc commented 1 year ago

What is the status of this?

zhuyaliang commented 1 year ago

@lukefromdc It will be updated later

rbuj commented 1 year ago

@zhuyaliang I'm no longer part of MATE team. I hope another team member will review your changes, regards.

raveit65 commented 1 year ago

Are the conversations resolved?

raveit65 commented 1 year ago

@zhuyaliang Build runs fine with debian at travis CI now. So what we do with the unsolved conversations? Did you fix them?