search

mate-desktop / mate-applets

Applets for use with the MATE panel
http://www.mate-desktop.org
GNU General Public License v2.0
79 stars 67 forks source link

Fixed-size notes support #641

Open qmaldon opened 2 years ago

qmaldon commented 2 years ago

Hi all,

These changes apply to stickynotes only.

This is my first PR on a Mate repo. Please bear with me, since there are a few things that are not straightforward:

1) Multiple changes were done automatically by the build system into .po files. I understand these are translation files caused by a change I did in stickynotes/sticky-notes-preferences.ui 2) All changes were verified manually in my host (RHEL 8). I'm not sure if your CI/CD system will kick in during PR. 3) Is there a way to get this branch backported to 1.26?

What is being enhanced & fixed: 1) [Enhanced] Support for fixed size notes. That is, a mechanism to disallow notes resizing (on all notes). 2) [Bug fix] On a large note (vertical length > screen height), after restarting the stickynotes applet there are no verifications of the w,h sizes stored in the xml file; as consequence no automatic scrollbar is set, leading to an ugly and difficult to manage note. This is fixed now, since during startup a check based on screen size is done (propagated from existed code).

Please look at the following images to get an idea of the code changes:

Screenshot from 2022-09-04 20-09-07

Screenshot from 2022-09-04 20-09-27

I decided to make these changes since the stickynotes applet has been one of my main productivity tools since 2014 (I used to run RHEL 5 at that time).

Please let me know if there is any change needed or edit as you see fit.

Thanks

Quintin Maldonado

mbkma commented 2 years ago

Hi, thanks for contributing! Please do not change po files here. This will be overwritten by transifex anyway. To untrack po files, I belive it is git rm -r --cached <folder> I am not sure though.

qmaldon commented 2 years ago

Hi, thanks for contributing! Please do not change po files here. This will be overwritten by transifex anyway. To untrack po files, I belive it is git rm -r --cached <folder> I am not sure though.

Hi @mbkma , Removed .po changes from branch as suggested. Please have a look.

I think there is an issue in the debian build. Fedora looks good.

Is there a way to get this branch backported to 1.26?

Following up on this, perhaps it would be 1.26.2?

Thanks

Quintin Maldonado