mate-desktop / mate-applets

Applets for use with the MATE panel
http://www.mate-desktop.org
GNU General Public License v2.0
79 stars 67 forks source link

gcc14: stable 1.26.1 release failed to build on fedora rawhide #663

Closed raveit65 closed 8 months ago

raveit65 commented 8 months ago

With gcc14 [-Wincompatible-pointer-types] warnings will treat as error in result mate-applets failed to build for fedora rawhide (next fedora 40 ). See https://kojipkgs.fedoraproject.org//work/tasks/3834/112323834/build.log

command.c: In function ‘command_applet_fill’:
command.c:472:59: error: passing argument 1 of ‘gtk_widget_get_accessible’ from incompatible pointer type [-Wincompatible-pointer-types]
  472 |     atk_widget = gtk_widget_get_accessible (command_applet->applet);
      |                                             ~~~~~~~~~~~~~~^~~~~~~~
      |                                                           |
      |                                                           MatePanelApplet * {aka struct _MatePanelApplet *}
In file included from /usr/include/gtk-3.0/gtk/gtkapplication.h:27,
                 from /usr/include/gtk-3.0/gtk/gtkwindow.h:33,
                 from /usr/include/gtk-3.0/gtk/gtkdialog.h:32,
                 from /usr/include/gtk-3.0/gtk/gtkaboutdialog.h:30,
                 from /usr/include/gtk-3.0/gtk/gtk.h:31,
                 from command.c:31:
/usr/include/gtk-3.0/gtk/gtkwidget.h:1067:79: note: expected ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} but argument is of type ‘MatePanelApplet *’ {aka ‘struct _MatePanelApplet *’}
 1067 | AtkObject*       gtk_widget_get_accessible               (GtkWidget          *widget);
      |                                                           ~~~~~~~~~~~~~~~~~~~~^~~~~~

Seems the warning is already fixed in master. https://github.com/mate-desktop/mate-applets/commit/a6c354617a1e5876308df5007cd52907b3d742f9 I will cherry-pick that commit to 1.26 branch.

raveit65 commented 8 months ago

Build is fixed in fedora.