typing-break: Fix compilation warnings and replace deprecated functions

[zhuyaliang]

@lukefromdc The problem has been fixed. Please test again

[zhuyaliang]

After the code is merged, I will remove the deprecated gtk_status_icon APIS and make the indicator a mandatory dependency

To do that, we need to update the appindicator code looked for to the ayatana version, right now it looks only for the older and often unavailable Ubuntu version. Trying to build with indicator support on my system with ayatana indicators for SNI gave this error: configure: error: appindicator-0.1 is not installed

[lukefromdc]

That was meant to be a separate comment quoting yours, somehow the site combined them

[raveit65]

The typing-break UI looks and works like before, same for notification-area applet.

[lukefromdc]

What is the status of this?

[raveit65]

@cwendling UI with a so called "black screen" and a view elements.

[cwendling]

@raveit65 yeah it's what I see as well; but again I don't think it's what the code is supposed to do. Anyway, it doesn't looks like a regression from master, so it doesn't matter for this PR.

[raveit65]

@cwendling Fedora use this default since you implemented it.

gsettings get org.mate.panel enable-sni-support
true

I guess AppIndicator support works when i see the menu of the applet, or not?

[cwendling]

@raveit65 if the applet is built with it, yes.

[lukefromdc]

Indicator (SNI) support for this capplet still looks for the older Ubuntu libappindicator not the current ayatana version. Porting might just be a matter of allowing the capplet to build against the ayatana version.

[raveit65]

Yes, mcc use --enable-appindicator build flag.