typing-break: Force dependency on appindicator3-0.1 and remove deprecated GtkStatusIcon

[zhuyaliang]

gsettings set org.mate.typing-break enabled true

[lukefromdc]

Latest force-pushed worked same as my last test, icon does not change. One difference that is harmless: with the status icon the tooltip shows time to next break, the menu shows it with the indicator.

[zhuyaliang]

@lukefromdc Leave this issue to future PR for resolution

[lukefromdc]

No problem, I've approved this PR and am fine with merging it. We'll deal with the icon updating later

[raveit65]

Beside from the build warning applet works same as before in fedora with UBUNTU_APPINDICATOR support.

[raveit65]

@cwendling We have unresolved conversations?

[lukefromdc]

@cwendling, is this ready to go or should we wait?

[raveit65]

If we really should produce build warnings this should be commented in code. Otherwise this can be removed in future again by mistake because we forgot why we accept a warning. Ihmo, i would prefer to leave code warnings free and wait for bugreport if it really produce a crash.

[cwendling]

If we really should produce build warnings this should be commented in code. Otherwise this can be removed in future again by mistake because we forgot why we accept a warning.

Fair enough. But it's actually none of our own code, it's just using GLib API as intended… so we could add a comment about that API being broken in that regard, but that'd look a tad odd :)

Ihmo, i would prefer to leave code warnings free and wait for bugreport if it really produce a crash.

Fair enough. But I'd rather not have crashes in the first place, because that's way nastier than a warning. Either way, in practice this probably doesn't actually matter because the property is gonna be of the right type, and currently g_variant_get_boolean() is safe enough.

So just as you guys like best, I don't mind.

[raveit65]

Good, than let us merge PR like it is :)