search

mate-desktop / mate-control-center

Utilities to configure the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
68 stars 59 forks source link

common: Fix compilation warnings replace deprecated functions gtk_rc_get_theme_dir and gtk_rc_scanner_new #734

Closed zhuyaliang closed 1 year ago

raveit65 commented 1 year ago

gtkrc is for gtk-2.0 themes. See https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/BlueMenta/gtk-2.0 for example. So do we need this code with gtk-3.0 themes?

zhuyaliang commented 1 year ago

gtkrc is for gtk-2.0 themes. See https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/BlueMenta/gtk-2.0 for example. So do we need this code with gtk-3.0 themes?

I know little about the theme, and I don't know how to add gtk3 support

raveit65 commented 1 year ago

Opps, i did a force push by accidental but i was able to restore previous state. I hope code is now OK.

raveit65 commented 1 year ago

gtkrc is for gtk-2.0 themes. See https://github.com/mate-desktop/mate-themes/tree/master/desktop-themes/BlueMenta/gtk-2.0 for example. So do we need this code with gtk-3.0 themes?

I know little about the theme, and I don't know how to add gtk3 support

Correct me if i am wrong. gtk_rc_get_theme_dir is used to find the directory where themes are installed and gtk_rc_scanner_new scans the gtk_color value in the theme_dir/gtk-2.0/gtkrc file. I am thinking minimum gtk_rc_scanner_new is obsolete because i can remove the `theme_dir/gtk-2.0/ folder from our themes and m-a-p find the theme with colors. Also, nowadays gtk-2.0 isn't use by any application any more, ihmo. I am thinking about to remove gtk-2.0 part from our themes because the gtk-murrine-engine which is used by gtk-2.0 themes will be removed from fedora soon. Any way, i will test for myself if both functions are really used nowadays.