mate-desktop / mate-desktop

Library with common API for various MATE modules
https://mate-desktop.org
GNU General Public License v2.0
446 stars 81 forks source link

Show LVM2 PV file systems and notice that the lvm2 package has to be installed in order to mount them #556

Open davidhedlund opened 1 year ago

davidhedlund commented 1 year ago

[I've also proposed this solution for GNOME: https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/49]

These GNU/Linux distributions has LVM2 PV installed by default.

However, Ubuntu does not inform that it cannot mount LMV2 PV without the lvm2 package installed. So it's moderately difficult for people to find why disk drives with Ubuntu Server, nor Trisquel, are not mounted in Ubuntu.

Expected behaviour

I expected that the device is listed, and when you click on it a pop-up dialog box show something like gparted (see below): "The following list of software packages is requried for lvm2 pv file system support: lvm2."

Screenshot at 2023-06-11 23-42-44

Actual behaviour

LVM2 PV without the lvm2 package installed

Screenshot from 2023-06-11 23-29-30 Screenshot from 2023-06-11 23-29-51

Screenshot at 2023-06-11 23-31-36 Screenshot at 2023-06-11 23-32-11

LVM2 PV with the lvm2 package installed + reboot

$ sudo apt-get install lvm2
[sudo] password for x: 
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  lvm2
0 upgraded, 1 newly installed, 0 to remove and 5 not upgraded.
Need to get 1 154 kB of archives.
After this operation, 4 129 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu jammy/main amd64 lvm2 amd64 2.03.11-2.1ubuntu4 [1 154 kB]
Fetched 1 154 kB in 1s (1 002 kB/s)   
Selecting previously unselected package lvm2.
(Reading database ... 308105 files and directories currently installed.)
Preparing to unpack .../lvm2_2.03.11-2.1ubuntu4_amd64.deb ...
Unpacking lvm2 (2.03.11-2.1ubuntu4) ...
Setting up lvm2 (2.03.11-2.1ubuntu4) ...
update-initramfs: deferring update (trigger activated)
Processing triggers for man-db (2.10.2-1) ...
Processing triggers for initramfs-tools (0.140ubuntu13.1) ...
update-initramfs: Generating /boot/initrd.img-5.19.0-43-generic
$ reboot

Screenshot from 2023-06-11 23-38-37

Screenshot at 2023-06-11 23-42-44

LVM-on-LUKS, without the lvm2 package installed

It can be a disconcerting experience to enter a password and then suddenly the file system thumbnail disappear. This can lead people to believe that they have either entered the wrong password or that the file system is damaged, which could result in them deciding to delete it in a worst-case scenario.

2023-05-29-194149_1920x1080_scrot 2023-05-29-194153_1920x1080_scrot 2023-05-29-194157_1920x1080_scrot 2023-05-29-194207_1920x1080_scrot 2023-05-29-194209_1920x1080_scrot

LVM-on-LUKS, with the lvm2 package installed

It mounted the file system. Screenshots not really needed, see the "LVM2 PV with the lvm2 package installed + reboot" section instead.

Steps to reproduce the behaviour

MATE general version

Package version

Linux Distribution

Ubuntu 22.04

Link to bugreport of your Distribution (requirement)

davidhedlund commented 1 year ago

Should I merge this issue to another repository?