search

mate-desktop / mate-media

Media tools for MATE
https://mate-desktop.org
GNU General Public License v2.0
19 stars 25 forks source link

Scroll volume in configurable steps same as media-keys #138

Closed gm10 closed 5 years ago

gm10 commented 5 years ago

Currently the volume stepping scrolling via the status icon is hardcoded to 5% of the 0-max range, whereas the volume stepping via the media keys is configurable and defaults to 6% of the available volume range, creating an annoying discrepancy in usability.

This pull request addresses that by using the existing settings key used by the media-keys plugin of mate-settings-daemon and calculating the stepping in the same way, so both media keys and scrolling via the icon change the volume in same-sized steps.

This also simplifies/optimizes some code at the end of that function.

raveit65 commented 5 years ago

I recall that we change volume-slider from 6 to 5 steps a while ago. Please search in git history for that commit. So, it might be better to sync media-keys to use 5 steps.

gm10 commented 5 years ago

@raveit65 stepping was always 5 in this one (edit: you may have been thinking of: b005276f2bb281b1bc2d1ef4ba18cdd43294d58f). I'm all for setting the default to 5 in media-keys as well but does that mean you want to hardcode it over there now then instead of keeping it configurable? Because once the user changes the default there we're back to where we are now, anyway.

Personally I like having it configurable although I guess since you're not exposing the setting in the GUI that is of limited value to the user base at large.

raveit65 commented 5 years ago

Really, i can choose 5 or 6% usage for m-s-d?. I am surprised after all that years :) Well in that case your change make sense. I only remember that there was a problem with using 6% for volume-slider. I need search for it .......

gm10 commented 5 years ago

@raveit65 yes, you can (and always could). For reference: https://github.com/mate-desktop/mate-settings-daemon/blob/master/plugins/media-keys/msd-media-keys-manager.c#L734

raveit65 commented 5 years ago

Found the gsettings key for m-s-d.

[rave@mother ~]$ gsettings get org.mate.SettingsDaemon.plugins.media-keys volume-step
6

Ok, than let us use 5% step for volume-slider and media-keys.

raveit65 commented 5 years ago

I squashed all commits in one. Merged https://github.com/mate-desktop/mate-media/commit/74f5181315401e5a2bb1a635ef3bc2ca9e51328a