mate-desktop / mate-media

Media tools for MATE
https://mate-desktop.org
GNU General Public License v2.0
19 stars 25 forks source link

Test Speakers silent #190

Open joakim-tjernlund opened 2 years ago

joakim-tjernlund commented 2 years ago

Did always play on DP/HDMI port 2 what ever output I selected. This little patch fixed it:

--- a/mate-volume-control/gvc-mixer-dialog.c    2022-06-24 05:29:30.252892748 +0200
+++ b/mate-volume-control/gvc-mixer-dialog.c    2022-06-24 05:29:58.353551464 +0200
@@ -1545,7 +1545,7 @@
                 return;
         }

-        stream = find_device_test_stream (dialog, device);
+        stream = mate_mixer_context_get_default_output_stream (dialog->priv->context);
         if (G_UNLIKELY (stream == NULL)) {
                 g_warn_if_reached ();
                 return;

Choosing output port requires multiple clicks on that port for it to be selected but I think that is a different issue

joakim-tjernlund commented 2 years ago

Also, the Mono speaker test can be make to play sound and not just noise by adding:

--- gvc-speaker-test.c.org  2022-06-26 14:04:52.236419200 +0200
+++ gvc-speaker-test.c  2022-06-26 14:11:36.486615875 +0200
@@ -174,6 +174,8 @@
                 return "audio-channel-front-right";
         case MATE_MIXER_CHANNEL_FRONT_CENTER:
                 return "audio-channel-front-center";
+        case MATE_MIXER_CHANNEL_MONO:
+                return "audio-channel-front-center";
         case MATE_MIXER_CHANNEL_BACK_LEFT:
                 return "audio-channel-rear-left";
         case MATE_MIXER_CHANNEL_BACK_RIGHT:
@@ -207,6 +209,10 @@
                 return playing
                         ? "audio-speaker-center-testing"
                         : "audio-speaker-center";
+        case MATE_MIXER_CHANNEL_MONO:
+                return playing
+                        ? "audio-speaker-center-testing"
+                        : "audio-speaker-center";
         case MATE_MIXER_CHANNEL_BACK_LEFT:
                 return playing
                         ? "audio-speaker-left-back-testing"

Did not find a Mono test so I just borrowed center-test

raveit65 commented 1 year ago

Can you prepare a pull request please?

raveit65 commented 1 year ago

And please use 2 commits as they are 2 issues after reading alsa and pulse reports.