search

mate-desktop / mate-media

Media tools for MATE
https://mate-desktop.org
GNU General Public License v2.0
19 stars 25 forks source link

Applet: port to in-process for wayland support #194

Closed lukefromdc closed 1 year ago

lukefromdc commented 1 year ago

Wayland cannot use xembed/GtkPlug/GtkSocket so port to in-process. The applet then works on wayland.

lukefromdc commented 1 year ago

In case we have ti have rhe option to build either way

On 6/13/2023 at 4:50 AM, "raveit65" @.***> wrote:

@raveit65 commented on this pull request.

@@ -508,12 +508,14 @@ menu_activate_open_volume_control (GtkAction action, GvcApplet applet) gboolean gvc_applet_fill (GvcApplet applet, MatePanelApplet applet_widget) {

  • /*This is for out of process only GdkEventMask event_mask;

I do not understand why commenting out this code instead of deleting when applet is build in-process? For what the non working code lines good for?

-- Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate- media/pull/194#pullrequestreview-1476614848 You are receiving this because you authored the thread.

Message ID: <mate-desktop/mate- @.***>

lukefromdc commented 1 year ago

I can keep these commented out or remove them. The git history will always be here if it's ever needed again

lukefromdc commented 1 year ago

Note that on wayland and only on wayland, the slider (like the calendar window) comes up center of screen. I will try to fix both of those later, x11 behavior here is same as before save for not listing the newly in-process applets as separate processes in top or in mate-system-monitor anymore as in-process means they are part of the panel itself when running.

lukefromdc commented 1 year ago

Just removed both commented out blocks, then retested on both x11 and wayland as insurance against typos. If they are ever needed again, they are in the git history