search

mate-desktop / mate-notification-daemon

Daemon to display passive pop-up notifications
https://mate-desktop.org
GNU General Public License v2.0
30 stars 26 forks source link

Implement Action icons Support #114

Closed ikeydoherty closed 7 years ago

ikeydoherty commented 7 years ago

This PR adds support to MATE Notification Daemon for the action-icons attribute, per capabilites + hints in the freedesktop Notifications Specification. These permit icons to be used in place of labels, with self describing icons (see 7aeebb6 in this PR for a full explanation)

It also exposed a number of bugs, subsequently fixed, in the existing themes when updating a live notification. The existing textual actions would disappear (gtk+-3.0 3.20) once a live notification is updated, for example by Rhythmbox.

It also turns out that pie_countdown's were duplicated or borky in one respect or another.

As this now returns functionality which has been missing for a while, it also exposed Coco buttons being quite ugly, and the pie_countdown in Slider having a black background. I feel these are out of scope for this pull request, and the visual styling for these elements, now correctly working, should be asserted by the MATE Desktop team, and not myself. The only recommendation I would make is that with the Slider theme, the actions_box align with the center horizontally when using action_icons, and retain end alignment when using textual actions.

The Solus MATE Notification Theme:

screenshot at 2016-11-16 19-00-24

Nodoka theme (part of core MATE Notification Daemon themes):

screenshot at 2016-11-16 18-43-53

flexiondotorg commented 7 years ago

@raveit65 @lukefromdc Please can you test this? Please also take a look at the "ugly" Coco buttons and the pie_countdown in Slider having a black background.

lukefromdc commented 7 years ago

The PR works, and in Audacious using Coco and with the tray applet enabled gives usable "pause" and "next" buttons using icons from the icon-theme. Background of the buttons is the gtk3 theme standard button background , which could be a mismatch in some GTK themes but works well in mine. That could of course be made themable within a theme by attaching a style class to the notification theme's toplevel window or to the buttons themselves.

Slider does not give a pie at all, I don't recall it ever having done so on my machines. EDIT: maybe an issue with my theme?

Still, I rather like this, especially for Audacious and will be keeping it installed for the moment

monsta commented 7 years ago

@ikeydoherty: thanks, merged :slightly_smiling_face:

ikeydoherty commented 7 years ago

Ta :)