search

mate-desktop / mate-notification-daemon

Daemon to display passive pop-up notifications
https://mate-desktop.org
GNU General Public License v2.0
30 stars 26 forks source link

PVS studio check #140

Open shlyakpavel opened 5 years ago

shlyakpavel commented 5 years ago

Hello. I have just examined the code with PVS studio static analyzer. The code is pretty clean. However, suspicious place was found: https://github.com/mate-desktop/mate-notification-daemon/blob/c586fe539efb8af372e60c752e03cb950cee9e77/src/daemon/daemon.c#L1565-L1590 Pay attention to the line 1565 where nt pointer is first used and the line 1590 where it is checked against nullptr. Null pointer dereference is possible. Thanks for providing us with stable and useful software! Have a nice day :)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/67599663-pvs-studio-check?utm_campaign=plugin&utm_content=tracker%2F1172660&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1172660&utm_medium=issues&utm_source=github).
raveit65 commented 1 year ago

Pull request please.

shlyakpavel commented 1 year ago

@raveit65 it may require extra investigation after 5 years I'll check it later