search

mate-desktop / mate-notification-daemon

Daemon to display passive pop-up notifications
https://mate-desktop.org
GNU General Public License v2.0
30 stars 26 forks source link

Use WARN_CFLAGS which are only set with --enable-compiler-warnings #160

Closed rbuj closed 4 years ago

sc0w commented 4 years ago

@mate-desktop/core-team

Personally, I prefer to build over master branch of mate-common directly, see https://github.com/mate-desktop/mate-notification-daemon/pull/161

raveit65 commented 4 years ago

Works fine, except of mix usage of tabs and spaces in configure summary.

[rave@mother mate-notification-daemon-dist]$ ./autogen.sh 

        compiler:                 gcc
    cflags:               -g -O2
        warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-notification-daemon-dist]$ ./configure --enable-compile-warnings=no

        compiler:                 gcc
    cflags:               -g -O2
        warning flags:            

[rave@mother mate-notification-daemon-dist]$ ./configure --enable-compile-warnings=yes

        compiler:                 gcc
    cflags:               -g -O2
        warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-notification-daemon-dist]$ ./configure --enable-compile-warnings=maximum

        compiler:                 gcc
    cflags:               -g -O2
        warning flags:            -Wall -Wmissing-prototypes -Wbad-function-cast -Wcast-align -Wextra -Wformat-nonliteral -Wmissing-declarations -Wmissing-field-initializers -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wno-sign-compare

[rave@mother mate-notification-daemon-dist]$ ./configure --enable-compile-warnings=error
        compiler:                 gcc
    cflags:               -g -O2
        warning flags:            -Wall -Wmissing-prototypes -Wbad-function-cast -Wcast-align -Wextra -Wformat-nonliteral -Wmissing-declarations -Wmissing-field-initializers -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wno-sign-compare -Werror

    dbus-1 system.d           /usr/local/etc/dbus-1/system.d
    dbus-1 services           ${prefix}/share/dbus-1/services

[rave@mother mate-notification-daemon-dist]$

@rbuj Can you please fix that?

mate-common-1.23.3 has everything what we need for this change. And it will reminds us to remove that from travis.yml in future when all distros use MATE-1.24. I don't think that someone wants to add more changes to mate-common now or i near future, or does someone has a plan for it? So building from 1.23.3 is sufficient.......IHMO.

sc0w commented 4 years ago

why I see in https://github.com/mate-desktop/mate-notification-daemon/pull/161 more warnings and here less warnings?

for example, these warnings are missing here:

 daemon.c: In function 'bus_acquired_handler_cb':

 daemon.c:146:20: warning: unused parameter 'name' [-Wunused-parameter]

   146 |   const gchar     *name,

       |   ~~~~~~~~~~~~~~~~~^~~~

 daemon.c: In function 'name_lost_handler_cb':

 daemon.c:172:52: warning: unused parameter 'connection' [-Wunused-parameter]

   172 | static void name_lost_handler_cb (GDBusConnection *connection,

       |                                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~

 daemon.c:173:20: warning: unused parameter 'name' [-Wunused-parameter]

   173 |   const gchar     *name,

       |   ~~~~~~~~~~~~~~~~~^~~~

 daemon.c:174:20: warning: unused parameter 'user_data' [-Wunused-parameter]

   174 |   gpointer         user_data)

       |   ~~~~~~~~~~~~~~~~~^~~~~~~~~

 daemon.c: In function 'do_exit':

 daemon.c:248:34: warning: unused parameter 'user_data' [-Wunused-parameter]

   248 | static gboolean do_exit(gpointer user_data)

       |                         ~~~~~~~~~^~~~~~~~~

 daemon.c: In function 'screen_xevent_filter':

 daemon.c:375:74: warning: unused parameter 'event' [-Wunused-parameter]

   375 | static GdkFilterReturn screen_xevent_filter(GdkXEvent* xevent, GdkEvent* event, NotifyScreen* nscreen)

       |                                                                ~~~~~~~~~~^~~~~

 daemon.c: In function 'on_popup_location_changed':

 daemon.c:416:50: warning: unused parameter 'settings' [-Wunused-parameter]

   416 | static void on_popup_location_changed(GSettings *settings, gchar *key, NotifyDaemon* daemon)

       |                                       ~~~~~~~~~~~^~~~~~~~

 In file included from /usr/include/glib-2.0/glib/gtypes.h:32,

                  from /usr/include/glib-2.0/glib/galloca.h:32,

                  from /usr/include/glib-2.0/glib.h:30,

                  from /usr/include/glib-2.0/glib/gi18n.h:21,

                  from daemon.c:31:

 daemon.c: In function '_action_invoked_cb':

 /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:99:38: warning: cast from function call of type 'gpointer' {aka 'void *'} to non-matching type 'long unsigned int' [-Wbad-function-cast]

    99 | #define GPOINTER_TO_UINT(p) ((guint) (gulong) (p))

       |                                      ^

 daemon.c:59:3: note: in expansion of macro 'GPOINTER_TO_UINT'

    59 |  (GPOINTER_TO_UINT(g_object_get_data(G_OBJECT(nw), "_notify_id")))

       |   ^~~~~~~~~~~~~~~~

 daemon.c:571:7: note: in expansion of macro 'NW_GET_NOTIFY_ID'

   571 |  id = NW_GET_NOTIFY_ID(nw);

       |       ^~~~~~~~~~~~~~~~

 daemon.c: In function '_emit_closed_signal':

 /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:99:38: warning: cast from function call of type 'gpointer' {aka 'void *'} to non-matching type 'long unsigned int' [-Wbad-function-cast]

    99 | #define GPOINTER_TO_UINT(p) ((guint) (gulong) (p))

       |                                      ^

 daemon.c:59:3: note: in expansion of macro 'GPOINTER_TO_UINT'

    59 |  (GPOINTER_TO_UINT(g_object_get_data(G_OBJECT(nw), "_notify_id")))

       |   ^~~~~~~~~~~~~~~~

 daemon.c:583:7: note: in expansion of macro 'NW_GET_NOTIFY_ID'

   583 |  id = NW_GET_NOTIFY_ID(nw);

       |       ^~~~~~~~~~~~~~~~

 daemon.c: In function '_notification_destroyed_cb':

 /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:99:38: warning: cast from function call of type 'gpointer' {aka 'void *'} to non-matching type 'long unsigned int' [-Wbad-function-cast]

    99 | #define GPOINTER_TO_UINT(p) ((guint) (gulong) (p))

       |                                      ^

 daemon.c:59:3: note: in expansion of macro 'GPOINTER_TO_UINT'

    59 |  (GPOINTER_TO_UINT(g_object_get_data(G_OBJECT(nw), "_notify_id")))

       |   ^~~~~~~~~~~~~~~~

 daemon.c:628:30: note: in expansion of macro 'NW_GET_NOTIFY_ID'

   628 |  _close_notification(daemon, NW_GET_NOTIFY_ID(nw), FALSE, NOTIFYD_CLOSED_EXPIRED);

       |                              ^~~~~~~~~~~~~~~~

 daemon.c: In function '_notify_x11_filter':

 daemon.c:682:72: warning: unused parameter 'event' [-Wunused-parameter]

   682 | static GdkFilterReturn _notify_x11_filter(GdkXEvent* xevent, GdkEvent* event, NotifyDaemon* daemon)

       |                                                              ~~~~~~~~~~^~~~~

 In file included from /usr/include/glib-2.0/glib/gtypes.h:32,

                  from /usr/include/glib-2.0/glib/galloca.h:32,

                  from /usr/include/glib-2.0/glib.h:30,

                  from /usr/include/glib-2.0/glib/gi18n.h:21,

                  from daemon.c:31:

 /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:99:38: warning: cast from function call of type 'gpointer' {aka 'void *'} to non-matching type 'long unsigned int' [-Wbad-function-cast]

    99 | #define GPOINTER_TO_UINT(p) ((guint) (gulong) (p))

       |                                      ^

 daemon.c:59:3: note: in expansion of macro 'GPOINTER_TO_UINT'

    59 |  (GPOINTER_TO_UINT(g_object_get_data(G_OBJECT(nw), "_notify_id")))

       |   ^~~~~~~~~~~~~~~~

 daemon.c:746:7: note: in expansion of macro 'NW_GET_NOTIFY_ID'

   746 |  id = NW_GET_NOTIFY_ID(nw);

       |       ^~~~~~~~~~~~~~~~

 In file included from /usr/include/glib-2.0/glib/gtypes.h:32,

                  from /usr/include/glib-2.0/glib/galloca.h:32,

                  from /usr/include/glib-2.0/glib.h:30,

                  from /usr/include/glib-2.0/glib/gi18n.h:21,

                  from daemon.c:31:

 daemon.c: In function '_mouse_exitted_cb':

 /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:99:38: warning: cast from function call of type 'gpointer' {aka 'void *'} to non-matching type 'long unsigned int' [-Wbad-function-cast]

    99 | #define GPOINTER_TO_UINT(p) ((guint) (gulong) (p))

       |                                      ^

 daemon.c:59:3: note: in expansion of macro 'GPOINTER_TO_UINT'

    59 |  (GPOINTER_TO_UINT(g_object_get_data(G_OBJECT(nw), "_notify_id")))

       |   ^~~~~~~~~~~~~~~~

 daemon.c:769:13: note: in expansion of macro 'NW_GET_NOTIFY_ID'

   769 |  guint id = NW_GET_NOTIFY_ID(nw);

       |             ^~~~~~~~~~~~~~~~

 daemon.c:775:38: warning: unused parameter 'key' [-Wunused-parameter]

   775 | static gboolean _is_expired(gpointer key, NotifyTimeout* nt, gboolean* phas_more_timeouts)

       |                             ~~~~~~~~~^~~

181c375,523
<   CC       mate_notification_daemon-stack.o
---
 daemon.c: In function '_notify_daemon_pixbuf_from_data_hint':

 daemon.c:964:44: warning: cast between incompatible function types from 'void (*)(void *)' to 'void (*)(guchar *, void *)' {aka 'void (*)(unsigned char *, void *)'} [-Wcast-function-type]

   964 |                                            (GdkPixbufDestroyNotify) g_free,

       |                                            ^

 In file included from /usr/include/glib-2.0/glib/gtypes.h:32,

                  from /usr/include/glib-2.0/glib/galloca.h:32,

                  from /usr/include/glib-2.0/glib.h:30,

                  from /usr/include/glib-2.0/glib/gi18n.h:21,

                  from daemon.c:31:

 daemon.c: In function 'window_clicked_cb':

 /usr/lib/x86_64-linux-gnu/glib-2.0/include/glibconfig.h:99:38: warning: cast from function call of type 'gpointer' {aka 'void *'} to non-matching type 'long unsigned int' [-Wbad-function-cast]

    99 | #define GPOINTER_TO_UINT(p) ((guint) (gulong) (p))

       |                                      ^

 daemon.c:59:3: note: in expansion of macro 'GPOINTER_TO_UINT'

    59 |  (GPOINTER_TO_UINT(g_object_get_data(G_OBJECT(nw), "_notify_id")))

       |   ^~~~~~~~~~~~~~~~

 daemon.c:1062:31: note: in expansion of macro 'NW_GET_NOTIFY_ID'

  1062 |  _close_notification (daemon, NW_GET_NOTIFY_ID (nw), TRUE, NOTIFYD_CLOSED_USER);

       |                               ^~~~~~~~~~~~~~~~

 daemon.c:1053:62: warning: unused parameter 'button' [-Wunused-parameter]

  1053 | static void window_clicked_cb(GtkWindow* nw, GdkEventButton* button, NotifyDaemon* daemon)

       |                                              ~~~~~~~~~~~~~~~~^~~~~~

 daemon.c: In function 'screensaver_active':

 daemon.c:1106:47: warning: unused parameter 'nw' [-Wunused-parameter]

  1106 | static gboolean screensaver_active(GtkWidget* nw)

       |                                    ~~~~~~~~~~~^~

 daemon.c: In function 'sync_notification_position':

 daemon.c:1245:54: warning: unused parameter 'daemon' [-Wunused-parameter]

  1245 | static void sync_notification_position(NotifyDaemon* daemon, GtkWindow* nw, Window source)

       |                                        ~~~~~~~~~~~~~~^~~~~~

 daemon.c: In function 'notify_daemon_notify_handler':

 daemon.c:1514:8: warning: declaration of 'x' shadows a previous local [-Wshadow]

  1514 |   gint x, y;

       |        ^

 daemon.c:1315:7: note: shadowed declaration is here

  1315 |  gint x = 0;

       |       ^

 daemon.c:1514:11: warning: declaration of 'y' shadows a previous local [-Wshadow]

  1514 |   gint x, y;

       |           ^

 daemon.c:1316:7: note: shadowed declaration is here

  1316 |  gint y = 0;

       |       ^

 daemon.c:1582:24: warning: declaration of 'data' shadows a previous local [-Wshadow]

  1582 |   _NotifyPendingClose* data;

       |                        ^~~~

 daemon.c:1312:12: note: shadowed declaration is here

  1312 |  GVariant* data;

       |            ^~~~

 daemon.c:1306:129: warning: unused parameter 'app_name' [-Wunused-parameter]

  1306 | static gboolean notify_daemon_notify_handler(NotifyDaemonNotifications *object, GDBusMethodInvocation *invocation, const gchar *app_name, guint id, const gchar *icon, const gchar *summary, const gchar *body, const gchar *const *actions, GVariant *hints, gint timeout, gpointer user_data)

       |                                                                                                                    ~~~~~~~~~~~~~^~~~~~~~

 daemon.c: In function 'notify_daemon_get_server_information':

 daemon.c:1645:134: warning: unused parameter 'user_data' [-Wunused-parameter]

  1645 | static gboolean notify_daemon_get_server_information (NotifyDaemonNotifications *object, GDBusMethodInvocation *invocation, gpointer user_data)

       |                                                                                                                             ~~~~~~~~~^~~~~~~~~

 engines.c: In function 'theme_changed_cb':

 engines.c:154:41: warning: unused parameter 'settings' [-Wunused-parameter]

   154 | static void theme_changed_cb(GSettings *settings, gchar *key, gpointer user_data)

       |                              ~~~~~~~~~~~^~~~~~~~

 engines.c:154:58: warning: unused parameter 'key' [-Wunused-parameter]

   154 | static void theme_changed_cb(GSettings *settings, gchar *key, gpointer user_data)

       |                                                   ~~~~~~~^~~

 engines.c:154:72: warning: unused parameter 'user_data' [-Wunused-parameter]

   154 | static void theme_changed_cb(GSettings *settings, gchar *key, gpointer user_data)

       |                                                               ~~~~~~~~~^~~~~~~~~

   CC       stack.o

 stack.c: In function 'get_origin_coordinates':

 stack.c:121:45: warning: unused parameter 'shiftx' [-Wunused-parameter]

   121 |                         gint               *shiftx,

       |                         ~~~~~~~~~~~~~~~~~~~~^~~~~~

 stack.c: In function 'translate_coordinates':

 stack.c:159:44: warning: unused parameter 'shiftx' [-Wunused-parameter]

   159 |                        gint               *shiftx,

       |                        ~~~~~~~~~~~~~~~~~~~~^~~~~~
221c563,585
<   CC       mate_notification_daemon-sound.o
---
   CC       sound.o

   CC       mnd-daemon.o

   CC       mnd-dbus-generated.o

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_override_properties':

 mnd-dbus-generated.c:559:64: warning: unused parameter 'klass' [-Wunused-parameter]

   559 | notify_daemon_notifications_override_properties (GObjectClass *klass, guint property_id_begin)

       |                                                  ~~~~~~~~~~~~~~^~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_complete_notify':

 mnd-dbus-generated.c:1236:32: warning: unused parameter 'object' [-Wunused-parameter]

  1236 |     NotifyDaemonNotifications *object,

       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_complete_close_notification':

 mnd-dbus-generated.c:1256:32: warning: unused parameter 'object' [-Wunused-parameter]

  1256 |     NotifyDaemonNotifications *object,

       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_complete_get_capabilities':

 mnd-dbus-generated.c:1275:32: warning: unused parameter 'object' [-Wunused-parameter]

  1275 |     NotifyDaemonNotifications *object,

       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_complete_get_server_information':

 mnd-dbus-generated.c:1299:32: warning: unused parameter 'object' [-Wunused-parameter]

  1299 |     NotifyDaemonNotifications *object,

       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_proxy_get_property':

 mnd-dbus-generated.c:1355:63: warning: unused parameter 'object' [-Wunused-parameter]

  1355 | notify_daemon_notifications_proxy_get_property (GObject      *object,

       |                                                 ~~~~~~~~~~~~~~^~~~~~

 mnd-dbus-generated.c:1356:17: warning: unused parameter 'prop_id' [-Wunused-parameter]

  1356 |   guint         prop_id,

       |   ~~~~~~~~~~~~~~^~~~~~~

 mnd-dbus-generated.c:1357:17: warning: unused parameter 'value' [-Wunused-parameter]

  1357 |   GValue       *value,

       |   ~~~~~~~~~~~~~~^~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_proxy_set_property':

 mnd-dbus-generated.c:1363:63: warning: unused parameter 'object' [-Wunused-parameter]

  1363 | notify_daemon_notifications_proxy_set_property (GObject      *object,

       |                                                 ~~~~~~~~~~~~~~^~~~~~

 mnd-dbus-generated.c:1364:17: warning: unused parameter 'prop_id' [-Wunused-parameter]

  1364 |   guint         prop_id,

       |   ~~~~~~~~~~~~~~^~~~~~~

 mnd-dbus-generated.c:1365:17: warning: unused parameter 'value' [-Wunused-parameter]

  1365 |   const GValue *value,

       |   ~~~~~~~~~~~~~~^~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_proxy_iface_init':

 mnd-dbus-generated.c:1473:79: warning: unused parameter 'iface' [-Wunused-parameter]

  1473 | notify_daemon_notifications_proxy_iface_init (NotifyDaemonNotificationsIface *iface)

       |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~

 mnd-dbus-generated.c: In function 'notify_daemon_notifications_skeleton_dbus_interface_flush':

 mnd-dbus-generated.c:1865:84: warning: unused parameter '_skeleton' [-Wunused-parameter]

  1865 | notify_daemon_notifications_skeleton_dbus_interface_flush (GDBusInterfaceSkeleton *_skeleton)

       |                                                            ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
239c677,743
<   CC       libcoco_la-coco-theme.lo
---
   CC       coco-theme.lo

 coco-theme.c: In function 'activate_link':

 coco-theme.c:111:26: warning: unused parameter 'label' [-Wunused-parameter]

   111 | activate_link (GtkLabel *label, const char *url, WindowData *windata)

       |                ~~~~~~~~~~^~~~~

 coco-theme.c: In function 'fill_background':

 coco-theme.c:139:28: warning: unused parameter 'widget' [-Wunused-parameter]

   139 | fill_background(GtkWidget *widget, WindowData *windata, cairo_t *cr)

       |                 ~~~~~~~~~~~^~~~~~

 coco-theme.c: In function 'draw_pie':

 coco-theme.c:165:21: warning: unused parameter 'pie' [-Wunused-parameter]

   165 | draw_pie(GtkWidget *pie, WindowData *windata, cairo_t *cr)

       |          ~~~~~~~~~~~^~~

 coco-theme.c: In function 'action_clicked_cb':

 coco-theme.c:335:49: warning: unused parameter 'event' [-Wunused-parameter]

   335 | action_clicked_cb(GtkWidget *w, GdkEventButton *event,

       |                                 ~~~~~~~~~~~~~~~~^~~~~

 coco-theme.c: In function 'set_notification_arrow':

 coco-theme.c:550:35: warning: unused parameter 'nw' [-Wunused-parameter]

   550 | set_notification_arrow(GtkWidget *nw, gboolean visible, int x, int y)

       |                        ~~~~~~~~~~~^~

 coco-theme.c:550:48: warning: unused parameter 'visible' [-Wunused-parameter]

   550 | set_notification_arrow(GtkWidget *nw, gboolean visible, int x, int y)

       |                                       ~~~~~~~~~^~~~~~~

 coco-theme.c:550:61: warning: unused parameter 'x' [-Wunused-parameter]

   550 | set_notification_arrow(GtkWidget *nw, gboolean visible, int x, int y)

       |                                                         ~~~~^

 coco-theme.c:550:68: warning: unused parameter 'y' [-Wunused-parameter]

   550 | set_notification_arrow(GtkWidget *nw, gboolean visible, int x, int y)

       |                                                                ~~~~^

 coco-theme.c: In function 'clear_notification_actions':

 coco-theme.c:647:9: warning: cast between incompatible function types from 'void (*)(GtkWidget *)' {aka 'void (*)(struct _GtkWidget *)'} to 'void (*)(GtkWidget *, void *)' {aka 'void (*)(struct _GtkWidget *, void *)'} [-Wcast-function-type]

   647 |         (GtkCallback)gtk_widget_destroy, NULL);

       |         ^

 nodoka-theme.c: In function 'activate_link':

 nodoka-theme.c:128:26: warning: unused parameter 'label' [-Wunused-parameter]

   128 | activate_link (GtkLabel *label, const char *url, WindowData *windata)

       |                ~~~~~~~~~~^~~~~

 nodoka-theme.c: In function 'fill_background':

 nodoka-theme.c:368:28: warning: unused parameter 'widget' [-Wunused-parameter]

   368 | fill_background(GtkWidget *widget, WindowData *windata, cairo_t *cr)

       |                 ~~~~~~~~~~~^~~~~~

 nodoka-theme.c: In function 'draw_stripe':

 nodoka-theme.c:395:24: warning: unused parameter 'widget' [-Wunused-parameter]

   395 | draw_stripe(GtkWidget *widget, WindowData *windata, cairo_t *cr)

       |             ~~~~~~~~~~~^~~~~~

 nodoka-theme.c: In function 'draw_border':

 nodoka-theme.c:474:24: warning: unused parameter 'widget' [-Wunused-parameter]

   474 | draw_border(GtkWidget *widget, WindowData *windata, cairo_t *cr)

       |             ~~~~~~~~~~~^~~~~~

 nodoka-theme.c: In function 'draw_pie':

 nodoka-theme.c:501:21: warning: unused parameter 'pie' [-Wunused-parameter]

   501 | draw_pie(GtkWidget *pie, WindowData *windata, cairo_t *cr)

       |          ~~~~~~~~~~~^~~

 nodoka-theme.c: In function 'action_clicked_cb':

 nodoka-theme.c:678:49: warning: unused parameter 'event' [-Wunused-parameter]

   678 | action_clicked_cb(GtkWidget *w, GdkEventButton *event,

       |                                 ~~~~~~~~~~~~~~~~^~~~~

 nodoka-theme.c: In function 'clear_notification_actions':

 nodoka-theme.c:1045:9: warning: cast between incompatible function types from 'void (*)(GtkWidget *)' {aka 'void (*)(struct _GtkWidget *)'} to 'void (*)(GtkWidget *, void *)' {aka 'void (*)(struct _GtkWidget *, void *)'} [-Wcast-function-type]

  1045 |         (GtkCallback)gtk_widget_destroy, NULL);

       |         ^
263c823,909
<   CC       libslider_la-theme.lo
---
   CC       theme.lo

 theme.c: In function 'fill_background':

 theme.c:145:60: warning: unused parameter 'windata' [-Wunused-parameter]

   145 | static void fill_background(GtkWidget* widget, WindowData* windata, cairo_t* cr)

       |                                                ~~~~~~~~~~~~^~~~~~~

 theme.c: In function 'on_window_map':

 theme.c:252:42: warning: unused parameter 'widget' [-Wunused-parameter]

   252 | static gboolean on_window_map(GtkWidget* widget, GdkEvent* event, WindowData* windata)

       |                               ~~~~~~~~~~~^~~~~~

 theme.c:252:60: warning: unused parameter 'event' [-Wunused-parameter]

   252 | static gboolean on_window_map(GtkWidget* widget, GdkEvent* event, WindowData* windata)

       |                                                  ~~~~~~~~~~^~~~~

 theme.c:252:79: warning: unused parameter 'windata' [-Wunused-parameter]

   252 | static gboolean on_window_map(GtkWidget* widget, GdkEvent* event, WindowData* windata)

       |                                                                   ~~~~~~~~~~~~^~~~~~~

 theme.c: In function 'on_window_realize':

 theme.c:294:42: warning: unused parameter 'widget' [-Wunused-parameter]

   294 | static void on_window_realize(GtkWidget* widget, WindowData* windata)

       |                               ~~~~~~~~~~~^~~~~~

 theme.c:294:62: warning: unused parameter 'windata' [-Wunused-parameter]

   294 | static void on_window_realize(GtkWidget* widget, WindowData* windata)

       |                                                  ~~~~~~~~~~~~^~~~~~~

 theme.c: In function 'set_notification_arrow':

 theme.c:617:53: warning: unused parameter 'visible' [-Wunused-parameter]

   617 | void set_notification_arrow(GtkWidget* nw, gboolean visible, int x, int y)

       |                                            ~~~~~~~~~^~~~~~~

 theme.c:617:66: warning: unused parameter 'x' [-Wunused-parameter]

   617 | void set_notification_arrow(GtkWidget* nw, gboolean visible, int x, int y)

       |                                                              ~~~~^

 theme.c:617:73: warning: unused parameter 'y' [-Wunused-parameter]

   617 | void set_notification_arrow(GtkWidget* nw, gboolean visible, int x, int y)

       |                                                                     ~~~~^

 theme.c: In function 'on_action_clicked':

 theme.c:685:61: warning: unused parameter 'event' [-Wunused-parameter]

   685 | static void on_action_clicked(GtkWidget* w, GdkEventButton *event, ActionInvokedCb action_cb)

       |                                             ~~~~~~~~~~~~~~~~^~~~~

 theme.c: In function 'clear_notification_actions':

 theme.c:781:61: warning: cast between incompatible function types from 'void (*)(GtkWidget *)' {aka 'void (*)(struct _GtkWidget *)'} to 'void (*)(GtkWidget *, void *)' {aka 'void (*)(struct _GtkWidget *, void *)'} [-Wcast-function-type]

   781 |  gtk_container_foreach(GTK_CONTAINER(windata-actions_box), (GtkCallback) gtk_widget_destroy, NULL);

       |                                                             ^

 theme.c: In function 'get_always_stack':

 theme.c:801:38: warning: unused parameter 'nw' [-Wunused-parameter]

   801 | gboolean get_always_stack(GtkWidget* nw)

       |                           ~~~~~~~~~~~^~
275c921,953
<   CC       libstandard_la-theme.lo
---
   CC       theme.lo

 theme.c: In function 'draw_border':

 theme.c:487:36: warning: unused parameter 'widget' [-Wunused-parameter]

   487 | static void draw_border(GtkWidget* widget, WindowData *windata, cairo_t* cr)

       |                         ~~~~~~~~~~~^~~~~~

 theme.c: In function 'activate_link':

 theme.c:634:41: warning: unused parameter 'label' [-Wunused-parameter]

   634 | static gboolean activate_link(GtkLabel* label, const char* url, WindowData* windata)

       |                               ~~~~~~~~~~^~~~~

 theme.c: In function 'action_clicked_cb':

 theme.c:992:61: warning: unused parameter 'event' [-Wunused-parameter]

   992 | static void action_clicked_cb(GtkWidget* w, GdkEventButton* event, ActionInvokedCb action_cb)

       |                                             ~~~~~~~~~~~~~~~~^~~~~

 theme.c: In function 'clear_notification_actions':

 theme.c:1085:61: warning: cast between incompatible function types from 'void (*)(GtkWidget *)' {aka 'void (*)(struct _GtkWidget *)'} to 'void (*)(GtkWidget *, void *)' {aka 'void (*)(struct _GtkWidget *, void *)'} [-Wcast-function-type]

  1085 |  gtk_container_foreach(GTK_CONTAINER(windata-actions_box), (GtkCallback) gtk_widget_destroy, NULL);

       |                                                             ^

 mate-notification-properties.c: In function 'notification_properties_position_notify':

 mate-notification-properties.c:91:10: warning: declaration of 'key' shadows a parameter [-Wshadow]

    91 |   gchar* key;

       |          ^~~

 mate-notification-properties.c:77:81: note: shadowed declaration is here

    77 | static void notification_properties_position_notify(GSettings *settings, gchar *key, NotificationAppletDialog* dialog)

       |                                                                          ~~~~~~~^~~

 mate-notification-properties.c:77:64: warning: unused parameter 'settings' [-Wunused-parameter]

    77 | static void notification_properties_position_notify(GSettings *settings, gchar *key, NotificationAppletDialog* dialog)

       |                                                     ~~~~~~~~~~~^~~~~~~~

 mate-notification-properties.c: In function 'notification_properties_monitor_changed':

 mate-notification-properties.c:106:66: warning: unused parameter 'widget' [-Wunused-parameter]

   106 | static void notification_properties_monitor_changed(GtkComboBox* widget, NotificationAppletDialog* dialog)

       |                                                     ~~~~~~~~~~~~~^~~~~~

 mate-notification-properties.c: In function 'notification_properties_monitor_notify':

 mate-notification-properties.c:123:63: warning: unused parameter 'settings' [-Wunused-parameter]

   123 | static void notification_properties_monitor_notify(GSettings *settings, gchar *key, NotificationAppletDialog* dialog)

       |                                                    ~~~~~~~~~~~^~~~~~~~

 mate-notification-properties.c:123:80: warning: unused parameter 'key' [-Wunused-parameter]

   123 | static void notification_properties_monitor_notify(GSettings *settings, gchar *key, NotificationAppletDialog* dialog)

       |                                                                         ~~~~~~~^~~

 mate-notification-properties.c: In function 'notification_properties_location_changed':

 mate-notification-properties.c:147:67: warning: unused parameter 'widget' [-Wunused-parameter]

   147 | static void notification_properties_location_changed(GtkComboBox* widget, NotificationAppletDialog* dialog)

       |                                                      ~~~~~~~~~~~~~^~~~~~

 mate-notification-properties.c: In function 'notification_properties_theme_notify':

 mate-notification-properties.c:251:61: warning: unused parameter 'settings' [-Wunused-parameter]

   251 | static void notification_properties_theme_notify(GSettings *settings, gchar *key, NotificationAppletDialog* dialog)

       |                                                  ~~~~~~~~~~~^~~~~~~~

 mate-notification-properties.c: In function 'notification_properties_theme_changed':

 mate-notification-properties.c:277:64: warning: unused parameter 'widget' [-Wunused-parameter]

   277 | static void notification_properties_theme_changed(GtkComboBox* widget, NotificationAppletDialog* dialog)

       |                                                   ~~~~~~~~~~~~~^~~~~~

 mate-notification-properties.c: In function 'notification_properties_dialog_destroyed':

 mate-notification-properties.c:533:65: warning: unused parameter 'widget' [-Wunused-parameter]

   533 | static void notification_properties_dialog_destroyed(GtkWidget* widget, NotificationAppletDialog* dialog)

       |                                                      ~~~~~~~~~~~^~~~~~
rbuj commented 4 years ago

@sc0w I fixed it before that you edited your previous comment. Anyway, thanks for the detailed log ;-) The autogen.sh compiler warning flags are overridden in configure step.