search

mate-desktop / mate-notification-daemon

Daemon to display passive pop-up notifications
https://mate-desktop.org
GNU General Public License v2.0
30 stars 26 forks source link

wayland: do not attempt to connect to x11 screensaver #217

Closed lukefromdc closed 1 year ago

lukefromdc commented 1 year ago

Fix https://github.com/mate-desktop/mate-notification-daemon/issues/216

lukefromdc commented 1 year ago

Stopped this warning on sending a notification to m-n-d and allows it to keep going after a suspend to ram:

** (mate-notification-daemon:6139): WARNING **: 21:58:47.966: Failed to get dbus connection: Error calling StartServiceByName for org.mate.ScreenSaver: Process org.mate.ScreenSaver exited with status 1

raveit65 commented 1 year ago

This fixes the issue in wayland session. During testing i noticed that x11 session isn't locked by mate-screensaver after suspend/hibernate. After hard testing and 20-30 restarts i found out that mate-session-manager is the culprit. Something between mate-session-manager-1.27.0 and current master do break the lock-screen. So, please wait with merging until we know whats going on.

raveit65 commented 1 year ago

@lukefromdc @zhuyaliang @mate-desktop/core-team Culprit is https://github.com/mate-desktop/mate-session-manager/commit/92c9a82105b222a934e994a87738673351ad33ee :/ Should i simple revert commit or does someone wants to look at it?

zhuyaliang commented 1 year ago

Should i simple revert commit or does someone wants to look at it?

@raveit65 I think we can open the issue in mate-session-manager. I will fix it when there is plenty of time

raveit65 commented 1 year ago

Done https://github.com/mate-desktop/mate-session-manager/issues/308

raveit65 commented 1 year ago

This PR is unrelated to suspend/hibernate issue with x11. Should i merge it or is there another reviewer?

raveit65 commented 1 year ago

I like to do a new release, so merging this PR.