search

mate-desktop / mate-notification-daemon

Daemon to display passive pop-up notifications
https://mate-desktop.org
GNU General Public License v2.0
30 stars 26 forks source link

daemon: fix "GValueArray is deprecated" warnings #80

Closed GiedriusS closed 8 years ago

GiedriusS commented 8 years ago

GValueArray is deprecated so move to GArray instead in _notify_daemon_pixbuf_from_data_hint(). Tested by showing some notifications with image hints.

raveit65 commented 8 years ago

Do you have a example for the -h option of notify-send? In general the PR looks good and reduce the build warnings.

GiedriusS commented 8 years ago

I used "-i" for random testing and Spotify showed some notifications with album art. Anyway, all data passed to this function is passed from libnotify and not from the user so it shouldn't change anything in this aspect. This is where these hints are setup in libnotify: http://libnotify.sourcearchive.com/documentation/0.7.3-2/notification_8c_source.html notify_notification_set_image_from_pixbuf()

raveit65 commented 8 years ago

ahh good, -i (icon) is working well :) I was a bit confused about description.

raveit65 commented 8 years ago

merged https://github.com/mate-desktop/mate-notification-daemon/commit/7d162d83a2008c25b3134fcdda8265f23d461585 Thank you