search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
184 stars 116 forks source link

tell dconf-edit about relocatable schemas #1355

Closed dnk closed 1 year ago

dnk commented 1 year ago

support for dconf-editor relocatable schemas

dnk commented 1 year ago

here result of applying relocatable schema image

zhuyaliang commented 1 year ago

@dnk I don't quite understand the meaning of the commit message. Can you supplement the information and compress the submission

dnk commented 1 year ago

@zhuyaliang these changes are evolution of https://github.com/mate-desktop/mate-desktop/issues/300 dconf-editor did not use gsettings and cannot get information about relocatable schemas. which cause inability to view/edit mate-applets' preferences (path /org/mate/panel/objects//prefs) in dconf-editor.

dconf-editor have ca.desrt.dconf-editor.Settings:relocatable-schemas-user-paths to specify users' relocatable schemas

gsettings describe ca.desrt.dconf-editor.Settings relocatable-schemas-user-paths

A dictionary that maps schema IDs with path specifications. It is used to allow the user to >associate a relocatable schema to certain paths. Path specifications may contain wildcards in >the form of empty segments (e.g. /ca/desrt/dconf-editor//), defining possibly multiple paths. >The same schema ID may be associated with multiple path specifications.`

this pull request update ca.desrt.dconf-editor.Settings:relocatable-schemas-user-paths to allow dconf-editor to use information about users' relocatable schema and to show it properly

zhuyaliang commented 1 year ago

@dnk Thank you for your explanation. I can test it now

L-U-T-i commented 1 year ago

@lukefromdc

wasn't able to find the custom font prefs from #1358

I've rebuilt mate-panel with both PRs (#1355 and #1358), and I can find both settings "custom-font" and "use-custom-font" in "/ org / mate / panel /objects / clock / prefs" (dconf-editor-3.38.3-3.el9.x86_64).

lukefromdc commented 1 year ago

I'm not opposing merge of this, but it needs another reviewer. I find the UI of GNOME's current dconf-editor nearly unusable so I use a very old version that has the GNOME 2 UI but does not support relocatable schemas. Therefore, I could have encountered another issue unique to me even when testing with the later version of dconf-editor.

dnk commented 1 year ago

these changes went into libmate-panel-applet-4.so to see result it is need to relaunch applets with updated libmate-panel-applet-4.so

lukefromdc commented 1 year ago

I have the clock built in-process, so relaunching the panel relaunches the clock too

raveit65 commented 1 year ago

This will also detect old non usable forgotten settings in relocatable-schemas which can be removed. So +1 for merging it.

raveit65 commented 1 year ago

Is there another reviewer or should i merge it?