mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
184 stars 118 forks source link

Fix distribution of applet service files #1378

Closed cwendling closed 1 year ago

cwendling commented 1 year ago

Fix distribution of the applet service files sources when building from an in-process-configured build. This fixes make distcheck and tarballs in builds configured with --with-in-process-applets=all (or actually any in-process applet).

The issue was that the .service.in file was referenced indirectly in EXTRA_DIST, and the variable listed there was only filled in a conditional. Automake is not able to resolve this and see it still should distribute the reference of that variable, even if set conditionally. Fix this by always setting the variable properly, even if it's only used for out-of-process builds.

raveit65 commented 1 year ago

Good job :) This fixes the discheck issue with all build cases. Test case 1: ./autogen.sh --with-in-process-applets=all --enable-x11 --enable-wayland && make && make distcheck Compiling and building the tarball works fine. After that i was able to build from the generated tarball with in-process/out-of-process: ./configure --with-in-process-applets=all --enable-x11 --enable-wayland && make and ./configure --with-in-process-applets=none --enable-x11 --enable-wayland && make

Test case 2: ./autogen.sh --with-in-process-applets=none --enable-x11 --enable-wayland && make && make distcheck Compiling and building the tarball works fine. After that i was able to build from the generated tarball with in-process/out-of-process: ./configure --with-in-process-applets=none --enable-x11 --enable-wayland && make and ./configure --with-in-process-applets=all --enable-x11 --enable-wayland && make