search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
184 stars 116 forks source link

wayland: stop panel "dodging" mouse and moving to top #1391

Closed lukefromdc closed 1 year ago

lukefromdc commented 1 year ago

*Panel grabs in wayland cause the whole panel to jump to the top, so disable them when not in x11

lukefromdc commented 1 year ago

Fixes https://github.com/mate-desktop/mate-panel/issues/1156

lukefromdc commented 1 year ago

Note that the pointer still changes to a hand, I've not figured out how to stop that, input is welcome on how to remove that as well so users don't think the panel is draggable

raveit65 commented 1 year ago

Ok, i learned that it is possible to move the panel in wayland. In report i thought grabbing the panel in general was broken. In my test it is possible to move the panel to the right or left screen edge if i do not release my trackball button to early. Should be the same with a standard mouse. Also, it is possible to move the panel back to bottom. Well, this is a bit harder but it works. So, i am thinking it is fixable and i am not sure that this feature should be disabled for wayland in general in this early stage. I mean we are far a way from a production wayland session. Minimum you should add a FIXME to code when you want to disable it.

raveit65 commented 1 year ago

And without disabling the cursor hand it is more confusing because everybody think grabbing is possible.

lukefromdc commented 1 year ago

Should we close this since it is possible (though buggy) to grab and move the panel in wayland as master now stands? We can leave this issue as an outstanding bug at this stage if needed.

lukefromdc commented 1 year ago

Fixed the formatting in case folks want to play with this. One possible fix would be to limit panel grabbing in wayland to a non-expanded panel, not sure how this is being done in x11 but this would be same behavior if the pointer change to a hand can be suppressed on the expanded panel.

On an expanded panel in x11, a left click, middle click, scroll, or hover on empty space are all simply ignored

raveit65 commented 1 year ago

Should we close this since it is possible (though buggy) to grab and move the panel in wayland as master now stands? We can leave this issue as an outstanding bug at this stage if needed.

Agree.

lukefromdc commented 1 year ago

Keeping a local backup for the moment though the work was simple. We don't want to break unexpanded panel handling in Wayland as that would constitute a feature removal if Xorg ever goes away. We are a long way from feature parity in wayland but also have a while to get there.