mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
183 stars 115 forks source link

libmate-panel-applet: don't use panel plug to find the screen #1400

Closed lukefromdc closed 10 months ago

lukefromdc commented 11 months ago
lukefromdc commented 11 months ago

This is needed to allow building the dictionary applet in-process on x11. Note that the out of process dictionary applet in mate-utils from git master with any recent version of mate-panel seems to be broken at least in Debian Unstable. The dialog box containing the results never shows up. With an in-process port and build it works, and in-process opens the way for making it work in wayland, though for that we will need a wayland codepath either in this same function or replacing it in the dictionary applet

lukefromdc commented 11 months ago

Needed for https://github.com/mate-desktop/mate-utils/pull/353

raveit65 commented 11 months ago

Did you mean this dialog box? With current master. Bildschirmfoto zu 2023-08-10 14-12-48

raveit65 commented 11 months ago

Hmm, i used this commit but i can't add dictionary applet to the panel when build-in-process.

lukefromdc commented 11 months ago

Found out what is different with the dialog in your case: With current git master the dictionary applet on x11 usually works if the panel is on the top. With the panel on the bottom the dialog does not come up. For convenience that was with this PR for mate-panel still applied, had no trouble adding the applet.

We need to find out why you had trouble adding the out of process applet. Assuming you restarted the panel with each test build of the applet changing from in-process to out of process or vice-versa