search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
185 stars 118 forks source link

replace deprecated gtk-image-menu-item* #1409

Closed raveit65 closed 1 year ago

raveit65 commented 1 year ago

With last push i removed gtk_image_menu_item_set_always_show_image and runtime warnings are gone.

lukefromdc commented 1 year ago

the GTK_IS_IMAGE_MENU_ITEM macro seems to work fine, and we already use it in mate-desktop. With this in use the runtime warnings are gone and the entire status notfier built with no warnings at all with my usual build defaults.

Looks good to go here

lukefromdc commented 1 year ago

Turns out we lost the Places and System icons in the main menus and had a couple leftover deprecation warnings about gtk_image_menu_item That came from still defining these two menu items with GtkImageMenuItem and was easily fixed:

https://github.com/mate-desktop/mate-panel/pull/1410

raveit65 commented 1 year ago

Opps, i am using the classic panel menu in result i didn't saw that. Thanks.