search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
183 stars 115 forks source link

netspeed unusable on vertical panels #1411

Open pF-arQon opened 8 months ago

pF-arQon commented 8 months ago

Expected behaviour

netspeed accurately displays network activity

Actual behaviour

netspeed displays what is effectively random numbers netspeed-oof

Is that 5 megabits? 85? 965? Your guess is as good as mine. :)

Steps to reproduce the behaviour

Create a vertical panel, add the netspeed applet to it.

MATE general version

1.26

Package version

Linux Distribution

Ubuntu 22.04

Link to bugreport of your Distribution (requirement)

https://bugs.launchpad.net/ubuntu/+source/mate-applets/+bug/1841854 , which contains fixes for both this and the icon positioning bug

lukefromdc commented 8 months ago

I just tested a bunch of left panel widths, and found that this applet simply does not manage space well when confined horizontally. The minimum width necessary to allow the applet to be useful would be the amount needed to accomodate the decimal places though, it's never going to be possible to make it very useful on say, a 24 px vertical panel.

Three things could help though: shrinking instead of cutting the icon, being able to remove the units or place the units label under the numbers, and maybe ellipsizing the label text so that the least significant figure would always be the first to go, even with the panel on the right side of the screen.

Anyway, here's what I got:

On a 100px left panel: Netspeed_0n_100px_Panel

On a 76px left panel Netspeed_0n_76px_Panel

On a 56 px left panel: Netspeed_0n_56px_Panel

On a 36 px left panel: Netspeed_0n_36px_Panel

pF-arQon commented 7 months ago

Yeah, there are multiple issues with the code, though the icon problems are minor compared to the applet being literally nonfunctional since the 1.26 regression.

Like I say, all the bugs I've seen so far are fixed in the patches I posted six weeks ago, including the icon: they just need someone to actually merge them. There's not much point discussing cosmetic changes while even the most basic pieces are still broken, because the situation will be different once those are working.

lukefromdc commented 7 months ago

patches posted where? I don't see a PR concerning this

pF-arQon commented 3 months ago

In the first post:

https://bugs.launchpad.net/ubuntu/+source/mate-applets/+bug/1841854 , which contains fixes for both this and the icon positioning bug

There are more bugs with it - as you say, it's just not very good at coping with spacing/orientation - but my time is limited so I had to prioritize making it functional first.

lukefromdc commented 3 months ago

We cannot test and merge a PR from launchpad etc w/o manually cutting and pasting it into a PR ourselves. If you could do that we could then much more easily test it