search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
183 stars 115 forks source link

Various cleanups #1418

Closed cwendling closed 7 months ago

cwendling commented 7 months ago

All this was mostly found by cppcheck while I tried to improve its output in #1415. Not everything it reports is taken care of here, but a lot is.

raveit65 commented 7 months ago

Beside from the new warning it seems that the panel runs fine in quick test.

lukefromdc commented 7 months ago

What is the status of this? due to the number of file changes we may have to rewrite either this or other PR's to deal with merge conflicts, so I would prefer to have this finished and out of the way. The cleanups improve the quality of the code, and the cppcheck warning is but advice on how code could be further improved, not a build warning. Holding on merging this as dealing with that is an unanswered question at this time

cwendling commented 7 months ago

@lukefromdc IMO it's ready. I addressed @raveit65's comment although it's not really new from this PR, but my additional commit just marks a bunch of pointers const, so either the compiler will emit new warnings, or it's almost certainly free of behavioral changes.

lukefromdc commented 7 months ago

This works fine, save for not containing the pager hack which for obvious reasons in in a different PR

lukefromdc commented 7 months ago

Accidental closure on comment