search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
185 stars 118 forks source link

status-notifier: Plug large leak with icons from paths #1446

Closed cwendling closed 5 months ago

cwendling commented 5 months ago

When loading an icon from a path rather than the icon theme, we scale it down to match the scale we need[^1], but we leaked the original pixbuf in this case.

Fixes #1444.

[^1]: See commit e5c8646d8f6167fe2d3634a4604a1bf9ec8ee5af

lukefromdc commented 5 months ago

Travis issue is the Ruby one, I will fix that now

lukefromdc commented 5 months ago

Just rebased against master for the travis fix, will merge if that passes as we now have a second successful test and one which verifies this fixed the memory leak at https://github.com/mate-desktop/mate-panel/issues/1444#issuecomment-2176307508

lukefromdc commented 5 months ago

Cannot update translations, the new tzm translation files still generate errors. Thus will release 1.28.2 with the existing translations. This has broken updating translations in every package

lukefromdc commented 5 months ago

cherrypicked to 1.28 and release 1.28.2 with existing translations due to build failure if translations are updated.

lukefromdc commented 5 months ago

Anyone have a problem with cherrypicking to 1.26 as well? Lots of distro versions shipping that won't be updating to 1.28. Please advise

cwendling commented 5 months ago

@lukefromdc fine with me, it's a big enough leak that it's worth backporting, and it should apply cleanly there as well.

lukefromdc commented 5 months ago

Will do, thanks

lukefromdc commented 5 months ago

On trying to update travis.yml so a release would be possible I got this error: The command "./docker-build --name ${DISTRO} --config .build.yml --install" failed and exited with 1 during Will try reverting the travis change and cherrypicking to the 1.26 branch and see what happens.

lukefromdc commented 5 months ago

Same travis error with or without the deploy fix. I do not know how to fix that, so until that is fixed I cannot do a release for 1.26 carrying this cherrypick

raveit65 commented 5 months ago

@lukefromdc Try dist: jammy, see master/1.28 branch

lukefromdc commented 5 months ago

That solved the problem, will release 1.26.5 again using the existing translations due to breakage in seemingly all repos with the new ones

lukefromdc commented 5 months ago

Fixed, 1.26.1 (after the other travis fix, which I had to fiddle with) is out so all recent distros should pick this up