mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
185 stars 118 forks source link

ci: Bump dpl branches for Ruby 3 support #1454

Closed correctmost closed 1 month ago

correctmost commented 1 month ago

The CI error on master:

/home/travis/.rvm/gems/ruby-3.3.5/gems/cl-1.2.4/lib/cl/opts.rb:112:in `block in taint': undefined method `taint' for an instance of String (NoMethodError)

          [key, self[key] && self[key].secret? ? value.taint : value]
                                                      ^^^^^^

That error with Ruby 3 was fixed here: https://github.com/travis-ci/travis-cl/commit/e17a1b2bd2fe51eb9cc4fd90d19c8a12997717a0#diff-ee038a05d1feba327913a56ad3533ada6845400f2aa2a1b2b2d2584d4e2852ba

I'm hoping that bumping from https://github.com/travis-ci/dpl/releases/tag/v2.0.3-beta.4 to https://github.com/travis-ci/dpl/releases/tag/v2.0.5 pulls in the fix.

lukefromdc commented 1 month ago

Got an error that shows up only on releases:

You have already activated logger 1.6.0, but your Gemfile requires logger 1.6.1. Since logger is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports logger as a default gem. (Gem::LoadError)

correctmost commented 1 month ago

Got an error that shows up only on releases:

You have already activated logger 1.6.0, but your Gemfile requires logger 1.6.1. Since logger is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports logger as a default gem. (Gem::LoadError)

Hmm, 15de78fbd59dfded35c4eb24d1fd51a7a38647d3 might need to be cherry-picked to the 1.28 branch too

lukefromdc commented 1 month ago

Just did that, let's hope 1.28.4 gets out

lukefromdc commented 1 month ago

Thanks, that worked and 1.28.4 is out