search

mate-desktop / mate-panel

MATE panel
https://mate-desktop.org
GNU General Public License v2.0
184 stars 118 forks source link

Skype icon starts tiling after panel size 29 #793

Closed jarrard closed 5 years ago

jarrard commented 6 years ago

skypematepanelissue

Expected behaviour Skype Icon to scale correctly or just a single icon to appear centered at its scale bracket size.

Actual behaviour The Skype icon starts to tile itself resulting in a 1 1/2 icon at panel size 29 and a double icon at panel size 41.

Steps to reproduce the behaviour Occurs when panel is set to size 29 or above.

MATE general version 1.20.1

Package version mate-panel-1.20.1-1

Linux Distribution Manjaro MATE x86_64

Link to downstream report of your Distribution unknown

lukefromdc commented 5 years ago

You might want to check tray icons in gnome-panel too, again using system-config-printer-applet as the test case, with an icon theme using PNG icons

lukefromdc commented 5 years ago

You might want to check tray icons in gnome-panel too, again using system-config-printer-applet as the test case, with an icon theme using PNG icons

lukefromdc commented 5 years ago

I just pushed the GTK change to my laptop, The battery icon wasn't cutting today before installation so it will be a while before I know if that problem is also fixed. Still, I have not been able to get the icon to cut once since installation.

muktupavels commented 5 years ago

I only tested with gnome-panel...

jarrard commented 5 years ago

It's good that a solution exists, while I don't use MATE generally, I do have it installed and will try these PR commit changes myself sometime.

Typically I use Plasma which has no tray icon issues but perhaps they don't scale in the same way so they avoid running into these problems.

lukefromdc commented 5 years ago

So far as testing the GTK commit is concerned, GNOME panel and MATE panel have almost exactly the same code for showing the tray icon or did the last I checked. A couple minor changes (one being my force redraw work) but none that stopped this issue, so for this purpose you can test in gnome-panel, mate-panel, heck probably even XFCE's panel which reused a lot of gnome-panel tray code.

I just tested Guake, and there too the icon tiling problem is fixed. I will now find that issue report and link it to this one.

EDIT: Let's hope the GTK devs get this fix merged so it can go out in GTK 3.24.3

ghost commented 5 years ago

Good to hear a fix seems to have been found. Pity Debian (stable+bpo) is still only at GTK 3.22.11.1 so I guess it'll be some time yet before it may be in the repos. Not sure about sid, but I don't feel like having any of it. Is there a safe workaround to import the fix without breaking things to test and - hopefully - confirm it's working on my end - with LXDE?

muktupavels commented 5 years ago

Fix was merged in GTK...

lukefromdc commented 5 years ago

Thanks, I will pull GTK again from the 3.24 branch

ghost commented 5 years ago

No fun on Debian 9.6 (amd64 stable+bpo). All good, but hitting the gates to dep hell trying to pull Pango from sid -- test aborted. Too bad. Anyone any idea of an ETA when this will arrive in bpo?

muktupavels commented 5 years ago

apt-get source libgtk-3-0, add patch, rebuild?

monsta commented 5 years ago

Confirmed, I've patched GTK+ 3.22.11 in Debian Stretch with https://github.com/GNOME/gtk/commit/31d896c5cf5449fb1c24c7180cf3eea62c2f506e, and the problem is fixed for nm-applet, guake and skypeforlinux. Thanks @muktupavels, I'll send a debdiff with the fix to Debian BTS.

monsta commented 5 years ago

https://bugs.debian.org/910635