mate-desktop / mate-polkit

Authentication Agent for PolicyKit and MATE
https://mate-desktop.org
Other
14 stars 14 forks source link

Show what for users password is needed. #13

Open manu3l opened 10 years ago

manu3l commented 10 years ago

As written in a downstream bug, https://bugs.mageia.org/show_bug.cgi?id=12145 mate-polkit doesn't show if the needed password is an users or the root one. Other polkit agent like the Gnome one show an avater.

A simple text could be enough.

Thanks

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/16225245-show-what-for-users-password-is-needed?utm_campaign=plugin&utm_content=tracker%2F1587117&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1587117&utm_medium=issues&utm_source=github).
manu3l commented 10 years ago

capture du 2013-12-29 15 35 01

infirit commented 10 years ago

Hmm, you do not say what command/application you try to run that needs elevated privileges. And my French is terrible ;). I did look at how this shows in fedora 20 and it indeed does not show which user which indicates to me it wants the user's password :).

For me it states clearly it needs the root password. screenshot-authenticate screenshot-authenticate-1

manu3l commented 10 years ago

It is a soft inside Mageia to updates packages. The polkit policy is here: http://gitweb.mageia.org/software/rpmdrake/tree/polkit/org.mageia.drakrpm-update.policy.in

"For me it states clearly it needs the root password." In which distrib ? Btw if you didn't see I'm on mate-polkit 1.6.0, don't know what is Fedora using.

For the text, "An Application is is attempting to perform an action tha requires privileges. Auhthentification is required to perform this action." "Mot de passe" means "password".

infirit commented 10 years ago

I see you use auth_self_keep which means ask the password for the owner of the session. In gentoo the default used for most of these is auth_admin which typically is root. Do notice that for me it asks super user privileges and in your example it does not. IOW, it does say when it needs super user (or root) privileges.

I can imagine this may be confusing so making it explicit which user's password is requested is not a bad idea.

manu3l commented 10 years ago

In fact other are also auth_admin http://gitweb.mageia.org/software/rpmdrake/tree/polkit/org.mageia.drakrpm-addmedia.policy.in

But for this one per design it's user abilities. So the issue looks valid if the asked password is from another user than root. Will check latter on my side with other policy present here.

flexiondotorg commented 10 years ago

@leuhmanu Is it possible this is purely a translation related issue? Can check the strings original Englsi hstrings against the translated French at Transifex - https://www.transifex.com/organization/mate/dashboard/MATE

raveit65 commented 9 years ago

@manu3l Is this issue still exists with french translation?

hickford commented 8 years ago

Yes please to a clearer message! When I see the 'authentication is required' dialog I never know whether to type the root password or my own password (I use both su and sudo in the terminal).

An application is attempting to perform an action that requires privileges. Authentication is required to perform this action. Password:

To me that suggests it wants the root password, but testing it now, it actually wants my user password. Ideally the message would be idiotproof in clarify:

Authentication is required to perform this action. Your password:

or

Authentication is required to perform this action. Password for user tim:

authentication-is-required

hickford commented 8 years ago

Alternatively the message could mention the word 'sudo'. Anything that at a glance would tell me to type my password rather than root's password.

lukefromdc commented 8 years ago

Question: how many people are using MATE that don't know the sudo password is their password and not the root password? My sister would never know the difference, this sort of thing gets me phone calls for support.

hickford commented 8 years ago

@lukefromdc Good point. Do you think my first suggestion would be clear?

Authentication is required to perform this action. Your password:

lukefromdc commented 8 years ago

This would work fine for most people, who by automatic habit would use their normal password