search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 52 forks source link

WidthOfScreen and HeightOfScreen implementation #235

Closed sc0w closed 6 years ago

sc0w commented 6 years ago

This commit reverts:

https://github.com/mate-desktop/mate-power-manager/commit/f748d5794f02d02ba949ad1503ed72207efca40c

And it applies an alternative to fix the deprecated functions:

gdk_screen_get_width gdk_screen_get_height

raveit65 commented 6 years ago

@sc0w I am not really sure how to test this PR because of double code in m-s-d. https://github.com/mate-desktop/mate-settings-daemon/blob/master/plugins/common/msd-osd-window.c#L435 Btw. what code is used? I am guessing the code in m-s-d is prefered when both are installed, so this change needs to be done first in m-s-d for testing. This leads me to the question why not dropping the osd code here? I can't imagine that someone use m-p-m outside of MATE without using m-s-d.

sc0w commented 6 years ago

I will do the same to mate-settings-daemon (it is in my pending list)

Honestly, I have no idea how to test it

raveit65 commented 6 years ago

I remember having to work on both of them to get the OSD's to look right in the noncomposited case.

Ahh, got it, thanks for explanation.