search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

pushed by accidental #260

Closed raveit65 closed 5 years ago

raveit65 commented 6 years ago

I pushed a few commit to master without doing a PR. Can you please review/test those? https://github.com/mate-desktop/mate-power-manager/commit/c569240f040f7b4394336569c803f58bd85f6b01 https://github.com/mate-desktop/mate-power-manager/commit/d5d6e8cd07bf2b15defb01d355d48702c16d23f1 https://github.com/mate-desktop/mate-power-manager/commit/71eb5487cb205d5e637439305232f4bad626a04a https://github.com/mate-desktop/mate-power-manager/commit/b3c86df1178c9f64548554d9ba5f0a721560a230 @monsta @lukefromdc @sc0w @vkareh

monsta commented 6 years ago

The code looks ok to me. I can't test most of it though - it looks like something for a laptop.

lukefromdc commented 6 years ago

I will test this later today

lukefromdc commented 6 years ago

I just tested this in my laptop(a converted chromebook). Not only did it work, the battery icon now responds to change of state between charging and discharging. If others can verify this result, one of these (possibly https://github.com/mate-desktop/mate-power-manager/commit/d5d6e8cd07bf2b15defb01d355d48702c16d23f1) will have closed https://github.com/mate-desktop/mate-power-manager/issues/259

Assuming a change in an underlying library didn't fix it. I tested the brightness applet and it works, I don't have keyboard control of brightness that works on that machine and never did.

raveit65 commented 6 years ago

Not only did it work, the battery icon now responds to change of state between charging and discharging.

I can confirm that. Backporting to 1.20 ?

monsta commented 6 years ago

Cool. It should be indeed backported then.

raveit65 commented 6 years ago

I will test it first as patch with a 1.20.x tarball.

raveit65 commented 6 years ago

Ok, https://github.com/mate-desktop/mate-power-manager/commit/d5d6e8cd07bf2b15defb01d355d48702c16d23f1 with latest 1.20.x release fixes the issue too. So, it makes sense to backport the commit.

vkareh commented 6 years ago

These all work for me. I can see the battery tray icon responding to charge/discharge events :+1: Brightness applet also works as expected.

monsta commented 5 years ago

Ok... should we close this as tested?

lukefromdc commented 5 years ago

OK by me

raveit65 commented 5 years ago

gpm-button: replace deprecated Gdk functions is already in 1.20 branch, closing.