use libtool generated during build instead of external one - Githubissues

mate-desktop / mate-power-manager

Power management tool for the MATE desktop

https://mate-desktop.org

GNU General Public License v2.0

59 stars 52 forks source link

use libtool generated during build instead of external one #273

Closed monsta closed 5 years ago

monsta commented 5 years ago

This comes from the patch attached to https://bugs.debian.org/912842. I think the patch can be upstreamed.

Currently m-p-m is our only project that uses an external libtool binary (which is in libtool-bin package in Debian). This PR switches it to local, generated ./libtool.

How to test:

launch the build
check that ./libtool is generated
check that src/org.mate.PowerManager.*.h header files are still properly generated from src/org.mate.PowerManager.xxx.xml ones

raveit65 commented 5 years ago

reviewing is currently a never ending story. I approved 3 and found 6 new ones in my mailbox :P this is definitely too much!

lukefromdc commented 5 years ago

Should I hold this pending a review by @sunweaver or proceed to merge it?

sunweaver commented 5 years ago

Hi

On Saturday, 2 February 2019, lukefromdc wrote:

Should I hold this pending a review by @sunweaver or proceed to merge it?

PR looks good to me... Mike

-- Sent from my Sailfish device