search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 52 forks source link

[ci] Enable Clang Static Analyzer #284

Closed yetist closed 5 years ago

yetist commented 5 years ago

Clang analyzer and ./configure --without-keyring on debian.

sc0w commented 5 years ago

in this PR ./configure --without-keyring is running over clang analyzer, I think the build must fail if you remove libgnome-keyring-dev in debian packages

I noticed this line, it is related?, I don't know if it is possible to change it since the repos:

https://github.com/mate-desktop/mate-dev-scripts/blob/master/travis/docker-build#L847

sc0w commented 5 years ago

I think you can just enable clang analyzer here and other jobs can be done in other PRs

monsta commented 5 years ago

Hmm... is --without-keyring used only for scan-build here?

monsta commented 5 years ago

All checks passed, so I guess it's good to go?

Do you guys prefer Clang analyzer only on master branch? If yes, then not all the commits can be picked for 1.22 branch.

sc0w commented 5 years ago

@monsta do you mean the PR https://github.com/mate-desktop/mate-power-manager/pull/283 ? (1.20 branch)

It haven't clang analyzer

and if we like, I think https://github.com/mate-desktop/mate-power-manager/pull/283 can be picked / adapted for 1.22

raveit65 commented 5 years ago

Why? Please do not use Clang analyzer on stable branches! We don't do that in other packages.

raveit65 commented 5 years ago

You can fix issue of clang and ccpcheck on master.

monsta commented 5 years ago

I'm fine with that. #283 looks like it can be adapted, yes.

sc0w commented 5 years ago

@raveit65

Please do not use Clang analyzer on stable branches!

I don't understand you, you are wrong, I didn't say that, I didn't do that

sc0w commented 5 years ago

@monsta done with https://github.com/mate-desktop/mate-power-manager/pull/286