mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

Power Statistics cannot enable timerstats in Wakeups tab #305

Closed flexiondotorg closed 4 years ago

flexiondotorg commented 4 years ago

Expected behaviour

Power Statistics for the Processor should output Wakeup stats in the table.

Actual behaviour

The table is empty and Processor wakeups per second says GDBus.Error:org.freedesktop.UPower.GeneralError: cannot enable timerstats.

Steps to reproduce the behaviour

Open Power Statistics and click Processor.

MATE general version

1.22.2 and git master

Package version

1.22.2-0ubuntu2

Linux Distribution

Ubuntu MATE 19.10

Link to downstream report of your Distribution

None as yet.

flexiondotorg commented 4 years ago

This issue was not caused by #303. I tested 1.22 and git master with and without that patch applied.

flexiondotorg commented 4 years ago

I have just tested Ubuntu MATE 19.04 with mate-power-manager 1.20.3-2 and upower 0.99.10-1 and the same issue is present.

raveit65 commented 4 years ago

I can confirm the issue with released 1.22.2/1/0 and upower-0.99.10/9.

rbuj commented 4 years ago

CONFIG_TIMER_STATS was removed from Kernel https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.19-rc6&id=20dcfe1b7df4072a3c13bdb7506f7138125d0099

/proc/timer_stats (from Linux 2.6.21 until Linux 4.10) http://man7.org/linux/man-pages/man5/proc.5.html

raveit65 commented 4 years ago

Now i know why gnome-power-statistic doesn't display it any more, only my mouse device. Bildschirmfoto zu 2019-09-26 15-28-48

raveit65 commented 4 years ago

So we need that? https://gitlab.gnome.org/GNOME/gnome-power-manager/commit/8621440250db093f7ec614193126ada1f2eedd9e With a check for kernel-version?

flexiondotorg commented 4 years ago

Probably just drop it. Eventually there will be no kernels that support the feature.

Question is, what UI changes are required? On my desktop and VMs the only thing I see in Power Statistics is the broken time stats.

lukefromdc commented 4 years ago

This is confirmed here too, on kernel 5.3.0 and I concur that if it depends on a no longer avaliable kernel feature we should drop it.

GNOME did manage to find another way of doing this (at least with 2018 kernels) in their gnome-usage application if anyone wants to find a way to bring it back-or fork that whole application and port it to the MATE user interface for that matter.

Ph0rkoz commented 4 years ago

Yes, broken in latest linux mint. :(