mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

Use WARN_CFLAGS which are only set with --enable-compiler-warnings #306

Closed rbuj closed 4 years ago

rbuj commented 4 years ago

MATE_COMPILE_WARNINGS is present in configure.ac but WARN_CFLAGS variable is not used. git grep WARN_CFLAGS

It removes -enable-extra-warn=yes, since it is recommended to use -enable-compile-warnings=maximum.

It sets -enable-compiler-warnings=yes, the default value for all MATE packager for now.

It prints WARN_CFLAGS in summary table.

raveit65 commented 4 years ago

@rbuj I think we should we use MATE_COMPILE_WARNINGS([yes]) for all packages as default for normal compiling. Same as with mate-utils.

rbuj commented 4 years ago

@raveit65 done, I also added compiler warnings in summary table:

$ ./autogen.sh --prefix=/usr
...

                    MATE Power Manager 1.23.0
                  =============================

        prefix:                    /usr
        datadir:                   ${datarootdir}
        compiler:                  gcc
        cflags:                    -g -O2
        cwarnings:                 -Wall -Wmissing-prototypes
        gnome-keyring support:     yes
        Building extra applets:    yes
        Self test support:         no
        dbus-1 services dir:       ${datarootdir}/dbus-1/services

Now type `make' to compile mate-power-manager
raveit65 commented 4 years ago

@rbuj

I also added compiler warnings in summary table:

Very nice :)

I think i will revert changes for mate-common-1.22.1 in stable branch, to avoid to make all changes for compiling repos for 1.22 too. What do you think?

raveit65 commented 4 years ago

Just updated travis (ci) to latest mate-common release.